Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for 3.29 #1665

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

tomastigera
Copy link
Contributor

Product Version(s):

Issue:

Link to docs preview:

SME review:

  • An SME has approved this change.

DOCS review:

  • A member of the docs team has approved this change.

Additional information:

Merge checklist:

  • Deploy preview inspected wherever changes were made
  • Build completed successfully
  • Test have passed

@tomastigera tomastigera requested a review from a team as a code owner September 18, 2024 18:12
Copy link

netlify bot commented Sep 18, 2024

Deploy Preview succeeded!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/tigera/deploys/670e7e252b0da82487ffaf8d
😎 Deploy Preview https://deploy-preview-1665--tigera.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 27 (🟢 up 5 from production)
Accessibility: 90 (no change from production)
Best Practices: 75 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 18, 2024

Deploy Preview for calico-docs-preview-next ready!

Name Link
🔨 Latest commit 22b1aef
🔍 Latest deploy log https://app.netlify.com/sites/calico-docs-preview-next/deploys/6706ca6d1bd4ff0008c5ae0d
😎 Deploy Preview https://deploy-preview-1665--calico-docs-preview-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 46 (🟢 up 9 from production)
Accessibility: 90 (no change from production)
Best Practices: 83 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@ctauchen ctauchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. A few comments for you to have a look at.

calico/reference/felix/configuration.mdx Outdated Show resolved Hide resolved
calico/reference/felix/configuration.mdx Outdated Show resolved Hide resolved
calico/reference/felix/configuration.mdx Outdated Show resolved Hide resolved
calico/reference/felix/configuration.mdx Show resolved Hide resolved
calico/reference/felix/configuration.mdx Outdated Show resolved Hide resolved
calico/reference/felix/configuration.mdx Outdated Show resolved Hide resolved
Copy link
Collaborator

@ctauchen ctauchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits, please apply globally.

Do these changes belong in upcoming CE or CC versions?

calico/reference/felix/configuration.mdx Show resolved Hide resolved
calico/reference/felix/configuration.mdx Outdated Show resolved Hide resolved
calico/reference/felix/configuration.mdx Outdated Show resolved Hide resolved
calico/reference/felix/configuration.mdx Outdated Show resolved Hide resolved
calico/reference/felix/configuration.mdx Outdated Show resolved Hide resolved
calico/reference/felix/configuration.mdx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants