Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(pick v1.37) remove -waf-log-file flag (#3722) [do not merge yet] #3723

Open
wants to merge 3 commits into
base: release-v1.37
Choose a base branch
from

Conversation

electricjesus
Copy link
Member

  • remove -waf-log-file flag

  • fix copyright

  • make generate

Description

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

* remove -waf-log-file flag

* fix copyright

* make generate
@electricjesus electricjesus requested a review from a team as a code owner January 27, 2025 21:21
@marvin-tigera marvin-tigera added this to the v1.37.0 milestone Jan 27, 2025
@electricjesus electricjesus changed the title remove -waf-log-file flag (#3722) (pick) remove -waf-log-file flag (#3722) [do not merge yet Jan 27, 2025
@electricjesus electricjesus changed the title (pick) remove -waf-log-file flag (#3722) [do not merge yet (pick v1.37) remove -waf-log-file flag (#3722) [do not merge yet] Jan 27, 2025
electricjesus and others added 2 commits January 27, 2025 21:40
* Change felixconfig WAFEventLogsFileEnabled when necessary

* file generation

* generate files
@radTuti radTuti modified the milestones: v1.37.0, v1.37.1 Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants