Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vhotplug: Add vendor specific ethernet adapter support #1011

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

vunnyso
Copy link
Contributor

@vunnyso vunnyso commented Feb 12, 2025

Description of changes

Adding support for UE306 Ethernet Network Adapter which has vendor specific interface and does not have bInterfaceClass as Communications (2) and bInterfaceSubClass as "Ethernet Networking" (6) defined in "Configuration Descriptor" space.

Closes: #6168

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run make-checks and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status
  • Change requires full re-installation
  • Change can be updated with nixos-rebuild ... switch

Instructions for Testing

  • List all targets that this applies to:
  • Is this a new feature
    • List the test steps to verify:
  • If it is an improvement how does it impact existing functionality?
    i) Should fix Ethernet adapter not working in Net-VM

Adding support for UE306 Ethernet Network Adapter which
has vendor specific interface and does not have bInterfaceClass
as Communications and bInterfaceSubClass as "Ethernet Networking"
defined in "Configuration Descriptor" space.

Signed-off-by: Vunny Sodhi <[email protected]>
@vunnyso vunnyso temporarily deployed to internal-build-workflow February 12, 2025 12:15 — with GitHub Actions Inactive
@vunnyso vunnyso requested review from nesteroff and mbssrc and removed request for nesteroff February 12, 2025 12:15
@vunnyso vunnyso added the Needs Testing CI Team to pre-verify label Feb 12, 2025
@nesteroff
Copy link
Contributor

Nice catch on the typos! It means that previously entire device classes were passed to VMs. Now they should be passed only when both the class and subclass match.

@vunnyso vunnyso removed the Needs Testing CI Team to pre-verify label Feb 12, 2025
@brianmcgillion brianmcgillion merged commit 94de38f into tiiuae:main Feb 13, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants