Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TLS guard for storagevm #1012

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Conversation

mbssrc
Copy link
Collaborator

@mbssrc mbssrc commented Feb 12, 2025

Description of changes

Fix boot issue when givc TLS is disabled and Ghaf flashed by adding appropriate guard.

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run make-checks and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status
  • Change requires full re-installation
  • Change can be updated with nixos-rebuild ... switch

Tested on x1.

Instructions for Testing

  • List all targets that this applies to: x1
  • Is this a new feature
    • List the test steps to verify: Flash x1 image with givc TLS disabled vs. this fix
  • If it is an improvement how does it impact existing functionality?

Fix boot issue when givc TLS is disabled and Ghaf flashed by adding
appropriate guard.

Signed-off-by: Manuel Bluhm <[email protected]>
@mbssrc mbssrc temporarily deployed to internal-build-workflow February 12, 2025 14:43 — with GitHub Actions Inactive
@mbssrc mbssrc changed the title fix(givc): Add TLS guard for storagevm Add TLS guard for storagevm Feb 12, 2025
@brianmcgillion brianmcgillion merged commit de779eb into tiiuae:main Feb 13, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants