Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add audio refresh to the dell laptops #986

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brianmcgillion
Copy link
Collaborator

bring the dell laptops inline with the lenovo.

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run make-checks and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status
  • Change requires full re-installation
  • Change can be updated with nixos-rebuild ... switch

Instructions for Testing

  • List all targets that this applies to:
  • Is this a new feature
    • List the test steps to verify:
  • If it is an improvement how does it impact existing functionality?

bring the dell laptops inline with the lenovo.

Signed-off-by: Brian McGillion <[email protected]>
@brianmcgillion brianmcgillion temporarily deployed to internal-build-workflow January 31, 2025 08:50 — with GitHub Actions Inactive
@brianmcgillion brianmcgillion requested a review from josa41 January 31, 2025 08:51

# Force a PCI device rescan after resetting a device
# to refind the device on host after reset
rescanPciDevice = "0000:00:1f.0";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd test first without removePciDevice and rescanPciDevice options, those may not be always needed. With Lenovo X1 the audio device does not reset correctly when it is being passed through and laptop or audiovm shuts down or reboots.
If these are needed for Dell also it seems correct to me.

@brianmcgillion brianmcgillion marked this pull request as draft February 10, 2025 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants