Fix data race when IsReadOnly and other write operations are concurre…

…ntly invoked Signed-off-by: you06 <[email protected]>
tikv · Oct 17, 2024 · 76975d6 · 76975d6
1 parent c3e10ae
commit 76975d6
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/internal/unionstore/memdb_art.go b/internal/unionstore/memdb_art.go
@@ -138,6 +138,15 @@ func (db *artDBWithContext) BatchGet(ctx context.Context, keys [][]byte) (map[st
 	return m, nil
 }
 
+// Dirty implements the MemBuffer interface.
+func (db *artDBWithContext) Dirty() bool {
+	if !db.skipMutex {
+		db.RLock()
+		defer db.RUnlock()
+	}
+	return db.ART.Dirty()
+}
+
 // GetMetrics implements the MemBuffer interface.
 func (db *artDBWithContext) GetMetrics() Metrics { return Metrics{} }
 

diff --git a/internal/unionstore/memdb_rbt.go b/internal/unionstore/memdb_rbt.go
@@ -148,6 +148,15 @@ func (db *rbtDBWithContext) BatchGet(ctx context.Context, keys [][]byte) (map[st
 	return m, nil
 }
 
+// Dirty implements the MemBuffer interface.
+func (db *rbtDBWithContext) Dirty() bool {
+	if !db.skipMutex {
+		db.RLock()
+		defer db.RUnlock()
+	}
+	return db.RBT.Dirty()
+}
+
 // GetMetrics implements the MemBuffer interface.
 func (db *rbtDBWithContext) GetMetrics() Metrics { return Metrics{} }