Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: add the Benchmark tool for TiKV #1331

Open
wants to merge 34 commits into
base: master
Choose a base branch
from

Conversation

LykxSassinator
Copy link
Contributor

@LykxSassinator LykxSassinator commented May 9, 2024

Description

This pull request introduces a benchmark tool designed to evaluate the performance of a specific TiKV cluster without the necessity of deploying TiDB.
The motivation of this pr derives from the challenges associated with performance testing TiKV clusters, which typically require deploying one or more TiDB nodes. This process can be time-consuming, and issues related to performance regressions may not be promptly communicated to developers.

Therefore, this pull request offers a simplified implementation of the benchmark tool to address these concerns.

Attention

If you have any other suggestions or proposals regarding this tool, pls comment it. Welcome any advices.

Signed-off-by: lucasliang <[email protected]>
Signed-off-by: lucasliang <[email protected]>
Signed-off-by: lucasliang <[email protected]>
Signed-off-by: lucasliang <[email protected]>
Signed-off-by: lucasliang <[email protected]>
Signed-off-by: lucasliang <[email protected]>
Signed-off-by: lucasliang <[email protected]>
Signed-off-by: lucasliang <[email protected]>
Signed-off-by: lucasliang <[email protected]>
@ti-chi-bot ti-chi-bot bot added the dco-signoff: yes Indicates the PR's author has signed the dco. label Aug 7, 2024
Copy link

ti-chi-bot bot commented Aug 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lykxsassinator, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 22, 2024
Signed-off-by: lucasliang <[email protected]>
Signed-off-by: lucasliang <[email protected]>
Signed-off-by: lucasliang <[email protected]>
Signed-off-by: lucasliang <[email protected]>
Signed-off-by: lucasliang <[email protected]>
@LykxSassinator LykxSassinator marked this pull request as ready for review August 23, 2024 04:21
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 23, 2024
@LykxSassinator LykxSassinator changed the title [WIP] Benchmark tool for TiKV examples: add the Benchmark tool for TiKV Aug 23, 2024
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 23, 2024
@ekexium
Copy link
Contributor

ekexium commented Aug 26, 2024

Is a go.sum missing? Do we need tests for this tool? We may also need a manual or readme for it.
I think it is not the best option to put the tool in examples, maybe we can have a bin or tools directory for its, or even a standalone repo.

examples/benchtool/main.go Outdated Show resolved Hide resolved
@LykxSassinator
Copy link
Contributor Author

Is a go.sum missing? Do we need tests for this tool? We may also need a manual or readme for it. I think it is not the best option to put the tool in examples, maybe we can have a bin or tools directory for its, or even a standalone repo.

FYI, the reason why this tool is set under examples is used to make this tool accessible and easy to use, where the README.md is already specified.

And as for tests, the basic and offline tests have been done for it, which can be reviewed in https://pingcap-cn.feishu.cn/wiki/QtoIwKWqNiiYp7kTujIcjw4RnEh.

Meanwhile, it's acceptable to move this tool into an individual repo if we can make an agreement about this advice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has signed the dco. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants