Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new gc safepoint update interface #96

Open
haojinming opened this issue May 10, 2022 · 5 comments
Open

Use new gc safepoint update interface #96

haojinming opened this issue May 10, 2022 · 5 comments
Assignees
@haojinming
Labels
status/stale type/bug Something isn't working

Comments

@haojinming
Copy link
Contributor

haojinming commented May 10, 2022 •
edited
Loading

Bug Report

1. Describe the bug

Use new gc safepoint update interface

2. Minimal reproduce step (Required)

3. What did you see instead (Required)

4. What did you expect to see? (Required)

Use new gc safepoint update interface

5. What is your migration tool and TiKV version? (Required)

GC-Worker
@haojinming haojinming added the type/bug Something isn't working label May 10, 2022
@pingyu
Copy link
Collaborator

pingyu commented May 10, 2022

Still get & pass revision to update GC safe point interface.
p.s. In this scenario, revision will be `-1.

@haojinming haojinming self-assigned this May 10, 2022
@haojinming
Copy link
Contributor Author

@pingyu What revision is returned from GetGCMinServiceSafePointByServiceGroup interface in this scenario? Could gc-worker pass the returned revision to UpdateGCSafePointByServiceGroup or need hard code to -1?

@haojinming haojinming mentioned this issue May 10, 2022
Closed
@pingyu
Copy link
Collaborator

pingyu commented May 10, 2022

@pingyu What revision is returned from GetGCMinServiceSafePointByServiceGroup interface in this scenario?

-1. See here.

Could gc-worker pass the returned revision to UpdateGCSafePointByServiceGroup or need hard code to -1?

Yes. No hard code is needed.

@haojinming
Copy link
Contributor Author

ok, get it.

@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity.

@haojinming haojinming changed the title GC cannot be triggered when no service exists. Use new gc safepoint update interface Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haojinming haojinming

Labels
status/stale type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP][fix #96] Use new gc safepoint update interface haojinming/migration
2 participants
@pingyu @haojinming