Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][fix #96] Use new gc safepoint update interface #97

Closed
wants to merge 8 commits into from

Conversation

haojinming
Copy link
Contributor

@haojinming haojinming commented May 10, 2022

Signed-off-by: haojinming [email protected]

What problem does this PR solve?

Issue Number: close #96

Problem Description: If service safepoint is 0, GC cannot be triggered.

What is changed and how does it work?

If service safepoint is zero, use gc-worker safepoint as the gc safepoint to do update.

Code changes

Check List for Tests

This PR has been tested by at least one of the following methods:

  • Unit test
  • Manual test (add detailed scripts or steps below)

Side effects

  • No side effects

Related changes

@haojinming haojinming changed the title [fix #96] Handle the case that service safepoint is zero. [WIP][fix #96] Handle the case that service safepoint is zero. May 10, 2022
Signed-off-by: haojinming <[email protected]>
Signed-off-by: haojinming <[email protected]>
Signed-off-by: haojinming <[email protected]>
@github-actions
Copy link

This PR is stale because it has been open 30 days with no activity. Remove the status/stale label or comment or this PR will be closed in 7 days.

Signed-off-by: haojinming <[email protected]>
Signed-off-by: haojinming <[email protected]>
@haojinming haojinming marked this pull request as draft June 14, 2022 07:09
@haojinming haojinming changed the title [WIP][fix #96] Handle the case that service safepoint is zero. [WIP][fix #96] Use new gc safepoint update interface Jun 14, 2022
@github-actions
Copy link

This PR is stale because it has been open 30 days with no activity. Remove the status/stale label or comment or this PR will be closed in 7 days.

@github-actions
Copy link

This PR was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use new gc safepoint update interface
1 participant