Skip to content

Commit

Permalink
fix watch
Browse files Browse the repository at this point in the history
Signed-off-by: okJiang <[email protected]>
  • Loading branch information
okJiang committed Jan 26, 2025
1 parent 55ab136 commit a37c6d7
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
5 changes: 2 additions & 3 deletions pkg/mcs/scheduling/server/config/watcher.go
Original file line number Diff line number Diff line change
Expand Up @@ -186,10 +186,9 @@ func (cw *Watcher) initializeTTLConfigWatcher() error {
}

func (cw *Watcher) initializeSchedulerConfigWatcher() error {
prefixToTrim := cw.schedulerConfigPathPrefix + "/"
putFn := func(kv *mvccpb.KeyValue) error {
key := string(kv.Key)
name := strings.TrimPrefix(key, prefixToTrim)
name := strings.TrimPrefix(key, cw.schedulerConfigPathPrefix)
log.Info("update scheduler config", zap.String("name", name),
zap.String("value", string(kv.Value)))
err := cw.storage.SaveSchedulerConfig(name, kv.Value)
Expand All @@ -210,7 +209,7 @@ func (cw *Watcher) initializeSchedulerConfigWatcher() error {
key := string(kv.Key)
log.Info("remove scheduler config", zap.String("key", key))
return cw.storage.RemoveSchedulerConfig(
strings.TrimPrefix(key, prefixToTrim),
strings.TrimPrefix(key, cw.schedulerConfigPathPrefix),
)
}
cw.schedulerConfigWatcher = etcdutil.NewLoopWatcher(
Expand Down
3 changes: 1 addition & 2 deletions pkg/mcs/scheduling/server/rule/watcher.go
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,6 @@ func (rw *Watcher) initializeRuleWatcher() error {
}

func (rw *Watcher) initializeRegionLabelWatcher() error {
prefixToTrim := rw.regionLabelPathPrefix + "/"
// TODO: use txn in region labeler.
preEventsFn := func([]*clientv3.Event) error {
// It will be locked until the postEventsFn is finished.
Expand All @@ -229,7 +228,7 @@ func (rw *Watcher) initializeRegionLabelWatcher() error {
deleteFn := func(kv *mvccpb.KeyValue) error {
key := string(kv.Key)
log.Info("delete region label rule", zap.String("key", key))
return rw.regionLabeler.DeleteLabelRuleLocked(strings.TrimPrefix(key, prefixToTrim))
return rw.regionLabeler.DeleteLabelRuleLocked(strings.TrimPrefix(key, rw.regionLabelPathPrefix))
}
postEventsFn := func([]*clientv3.Event) error {
defer rw.regionLabeler.Unlock()
Expand Down

0 comments on commit a37c6d7

Please sign in to comment.