Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the Keyspace config name for the GC management type #8002

Closed
ystaticy opened this issue Mar 29, 2024 · 1 comment
Closed

Change the Keyspace config name for the GC management type #8002

ystaticy opened this issue Mar 29, 2024 · 1 comment
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@ystaticy
Copy link
Contributor

ystaticy commented Mar 29, 2024 •
edited
Loading

Enhancement Task

safe_point_version Config name in keyspace meta config make some confuse.
It need be changed to gc_management_type.

If gc_management_type is global_gc, it means the current keyspace requires a tidb without 'keyspace-name'
configured to run a global gc worker to calculate a global gc safe point.
If gc_management_type is keyspace_level_gc it means the current keyspace can calculate gc safe point by its own.
@ystaticy ystaticy added the type/enhancement The issue or PR belongs to an enhancement. label Mar 29, 2024
@ystaticy ystaticy mentioned this issue Mar 29, 2024
Merged
ti-chi-bot bot added a commit that referenced this issue Apr 1, 2024
@ystaticy @ti-chi-bot
client/http: change the keyspace config name for the GC management ty…
75b8a4b 
…pe (#8000)

ref #8002

Change `safe_point_version` to 'gc_management_type' in keyspace meta config

Signed-off-by: [email protected] <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@rleungx
Copy link
Member

rleungx commented Apr 11, 2024

Close it since it has been done.

@rleungx rleungx closed this as completed Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ystaticy @rleungx