Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client/http: change the keyspace config name for the GC management type #8000

Merged
merged 7 commits into from
Apr 1, 2024

Conversation

ystaticy
Copy link
Contributor

@ystaticy ystaticy commented Mar 29, 2024

What problem does this PR solve?

safe_point_version Config name in keyspace meta config make some confuse.
It need be changed to gc_management_type.

Issue Number: ref #8002

What is changed and how does it work?

Change `safe_point_version` to 'gc_management_type' in keyspace meta config 

If gc_management_type is global_gc, it means the current keyspace requires a tidb without 'keyspace-name'
configured to run a global gc worker to calculate a global gc safe point.
If gc_management_type is keyspace_level_gc it means the current keyspace can calculate gc safe point by its own.

After update Keyspace GC management type, query keyspace meta from PD, we can get as follows:

{
    "id": 1,
    "name": "ks1",
    "state": "ENABLED",
    "created_at": 1711703870,
    "state_changed_at": 1711703870,
    "config": {
        "gc_management_type": "keyspace_level_gc",    // It's in effect in this PR
        "tso_keyspace_group_id": "0",
        "user_kind": "basic"
    }
}

Check List

Tests

  • Unit test
    • TestUpdateKeyspaceGCManagementType

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

Change `safe_point_version` to 'gc_management_type' in keyspace meta config 

Copy link
Contributor

ti-chi-bot bot commented Mar 29, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Mar 29, 2024
Copy link
Contributor

ti-chi-bot bot commented Mar 29, 2024

Hi @ystaticy. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot requested review from JmPotato and rleungx March 29, 2024 06:04
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 29, 2024
@rleungx
Copy link
Member

rleungx commented Mar 29, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Mar 29, 2024
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Merging #8000 (8319e58) into master (945e29c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 8319e58 differs from pull request most recent head ea0cd69. Consider uploading reports for the commit ea0cd69 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8000   +/-   ##
=======================================
  Coverage   73.64%   73.65%           
=======================================
  Files         436      436           
  Lines       48503    48474   -29     
=======================================
- Hits        35722    35704   -18     
+ Misses       9727     9715   -12     
- Partials     3054     3055    +1     
Flag Coverage Δ
unittests 73.65% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ystaticy ystaticy changed the title keyspace config http interface: change config name Change the Keyspace config name for the GC management type Mar 29, 2024
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 29, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT1 Indicates that a PR has LGTM 1. and removed do-not-merge/needs-linked-issue labels Mar 29, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 1, 2024
@JmPotato JmPotato changed the title Change the Keyspace config name for the GC management type client/http: change the keyspace config name for the GC management type Apr 1, 2024
@JmPotato
Copy link
Member

JmPotato commented Apr 1, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Apr 1, 2024

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Apr 1, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 568190d

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 1, 2024
Copy link
Contributor

ti-chi-bot bot commented Apr 1, 2024

@ystaticy: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 75b8a4b into tikv:master Apr 1, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants