resource_manager: record the max RU per second

[nolouch]

What problem does this PR solve?

Issue Number: Close #7908

When I only run workload A:

sysbench --mysql-user=user1 --mysql-host=10.2.12.53 --mysql-port=32335 --table-size=10000000  oltp_read_only run --time=1000 --report-interval=1 --threads=4  --mysql-db=test --tables=32 --rate=2

RU Avg is OK because the workload is stable.

But When I manually run the big query SQL like:

select count(*) from test.sbtest1;

The monitoring was not very accurate(on-avg), which led me to mistakenly believe that I was far away from triggering RC control.

But from the slow query:

it cost 8000+ RU, and which let some query need wait in the RC queue

What is changed and how does it work?

resource_manager: record the max RU per second 

Check List

Tests

• Unit test
• Integration test

Release note

None.

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• CabinfeverB
• HuSharp

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[codecov]

Codecov Report

Merging #7936 (23db662) into master (955d30a) will increase coverage by 0.11%.
The diff coverage is 94.00%.

❗ Current head 23db662 differs from pull request most recent head 6ea61b4. Consider uploading reports for the commit 6ea61b4 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7936      +/-   ##
==========================================
+ Coverage   73.48%   73.60%   +0.11%     
==========================================
  Files         436      436              
  Lines       48376    48425      +49     
==========================================
+ Hits        35550    35644      +94     
+ Misses       9768     9721      -47     
- Partials     3058     3060       +2     

Flag	Coverage Δ
unittests	73.60% <94.00%> (+0.11%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[nolouch]

PTAL @glorv

[HuSharp]

Do we need to update metrics.json?

[glorv]

rest LGTM

[glorv]

Suggested change

	if maxPerSecTrackers[name] == nil {
	maxPerSecTrackers[name] = newMaxPerSecCostTracker(name, defaultCollectIntervalSec)
	}
	maxPerSecTrackers[name].Observe(rruSum[name], wruSum[name])
	if maxPerSecTrackers[name] == nil && (rruSum[name] + wruSum[name] > 0.0) {
	maxPerSecTrackers[name] = newMaxPerSecCostTracker(name, defaultCollectIntervalSec)
	}
	if maxPerSecTrackers[name] != nil {
	maxPerSecTrackers[name].Observe(rruSum[name], wruSum[name])
	}

Maybe skip inactive groups here is better

[nolouch]

It may be inactive for a period of time, and active for a period of time. To reflect this trend of change, the cost is acceptable

[nolouch]

ptal @glorv

[glorv]

LGTM

[nolouch]

/merge

[ti-chi-bot]

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 23db662

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.5: #7968.

[nolouch]

/run-cherry-picker

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.1: #8011.