Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: optimize heartbeat process with concurrent runner - part 2 #8052
*: optimize heartbeat process with concurrent runner - part 2 #8052
Changes from 2 commits
ef1bc25
3007e31
10de156
f67c8a8
15b1979
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 1038 in pkg/core/region.go
Codecov / codecov/patch
pkg/core/region.go#L1038
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a possibility that the following situation exists: I detected an overlap in the leaders tree and added
item.RegionInfo
, then, before I check other role trees, something like a leader transfer occurs. Will I not be able to get the latestitem.RegionInfo
because of this? Will there be any side effects?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here checks hold the lock, which means the new changes have not updated the subtree yet. So I think it's ok, then will handle the new updates.