-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
join, etcdutil: enable linearizable in MemberList #8564
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: lhy1024 <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -174,8 +175,15 @@ func PrepareJoinCluster(cfg *config.Config) error { | |||
listSucc bool | |||
) | |||
|
|||
// If there is only one member in the cluster, the cluster maybe lost leader | |||
// since quorum is not active after adding the new member. | |||
linearizable := true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ref #8552
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8564 +/- ##
==========================================
- Coverage 77.64% 77.63% -0.01%
==========================================
Files 474 474
Lines 61877 61884 +7
==========================================
+ Hits 48044 48045 +1
- Misses 10300 10305 +5
- Partials 3533 3534 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
/test pull-integration-realcluster-test |
What problem does this PR solve?
Issue Number: Close #8542
What is changed and how does it work?
Check List
Tests
Release note