scheduler_test: change scheduler check order #8613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: husharp <[email protected]>
ti-chi-bot
bot
added
release-note-none
ti-chi-bot
bot
added
the
size/S
rleungx
approved these changes
Sep 10, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
lhy1024
approved these changes
Sep 10, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lhy1024, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8613 +/- ##
==========================================
+ Coverage 77.61% 77.63% +0.02%
==========================================
Files 474 474
Lines 61891 61891
==========================================
+ Hits 48035 48050 +15
+ Misses 10310 10303 -7
+ Partials 3546 3538 -8
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: Close #8612
What is changed and how does it work?
It's better to wait scheduler callback finished.
Check List
Tests
Release note