Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: Add benchmark for tsoStream and tsoDispatcher #8618

Conversation

MyonKeminta
Copy link
Contributor

@MyonKeminta MyonKeminta commented Sep 12, 2024

What problem does this PR solve?

Issue Number: Ref #8432

What is changed and how does it work?

client: Add benchmark for tsoStream and tsoDispatcher

This PR adds some benchmarks that might be helpful for checking if there's any regression when working on #8432 .

Current result:

goos: linux
goarch: amd64
pkg: github.com/tikv/pd/client
cpu: Intel(R) Xeon(R) Silver 4214R CPU @ 2.40GHz
BenchmarkTSODispatcherHandleRequests-28           140149              7508 ns/op
BenchmarkTSOStreamSendRecv-28                    2788069               425.8 ns/op
PASS
ok      github.com/tikv/pd/client       2.796s

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

Copy link
Contributor

ti-chi-bot bot commented Sep 12, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has signed the dco. labels Sep 12, 2024
@ti-chi-bot ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 12, 2024
@MyonKeminta MyonKeminta force-pushed the m/add-benchmarks-for-tso-stream-and-dispatcher branch from 7ce6f4a to 67967e4 Compare September 12, 2024 04:14
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.60%. Comparing base (9af28fc) to head (ef6e365).
Report is 77 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8618      +/-   ##
==========================================
+ Coverage   77.48%   77.60%   +0.11%     
==========================================
  Files         472      474       +2     
  Lines       61798    61893      +95     
==========================================
+ Hits        47887    48032     +145     
+ Misses      10341    10317      -24     
+ Partials     3570     3544      -26     
Flag Coverage Δ
unittests 77.60% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@MyonKeminta MyonKeminta marked this pull request as ready for review September 12, 2024 07:32
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 12, 2024
Copy link
Contributor

@lhy1024 lhy1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix ci

Signed-off-by: MyonKeminta <[email protected]>
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 12, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

ti-chi-bot bot commented Sep 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-12 08:36:56.356713185 +0000 UTC m=+518286.097137144: ☑️ agreed by lhy1024.

@ti-chi-bot ti-chi-bot bot added the approved label Sep 12, 2024
@MyonKeminta
Copy link
Contributor Author

Already included in #8483 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants