Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pd-ctl, config: adjust the output of pd config #8695

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Oct 11, 2024

What problem does this PR solve?

Issue Number: Close #8694

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 11, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 12, 2024
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.97%. Comparing base (41bd2cd) to head (64595df).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8695      +/-   ##
==========================================
+ Coverage   69.94%   69.97%   +0.03%     
==========================================
  Files         517      517              
  Lines       79947    79947              
==========================================
+ Hits        55920    55946      +26     
+ Misses      20453    20433      -20     
+ Partials     3574     3568       -6     
Flag Coverage Δ
unittests 69.97% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 17, 2024
Copy link
Contributor

ti-chi-bot bot commented Oct 17, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-12 09:22:19.934010578 +0000 UTC m=+90137.082920410: ☑️ agreed by okJiang.
  • 2024-10-17 06:58:21.256476103 +0000 UTC m=+513498.405385937: ☑️ agreed by JmPotato.

@lhy1024
Copy link
Contributor Author

lhy1024 commented Oct 18, 2024

step1:
set election interval with 5s
image
step2:
patch with this pr
image

Copy link
Contributor

ti-chi-bot bot commented Oct 18, 2024

@lhy1024: You cannot manually add or delete the reviewing state labels, only I and the tursted members have permission to do so.

In response to adding label named approved.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot removed the approved label Oct 18, 2024
Copy link
Contributor

ti-chi-bot bot commented Oct 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, niubell, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 18, 2024
@ti-chi-bot ti-chi-bot bot merged commit f7c8e43 into tikv:master Oct 18, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pd-ctl, config: some configs are camel case in the result
4 participants