*: move tso to independent thread #8720

rleungx · 2024-10-16T04:27:31Z

What problem does this PR solve?

Issue Number: Ref #8477.

What is changed and how does it work?

This is a part of #8517.

Check List

Tests

Unit test

Release note

None.

JmPotato · 2024-10-16T06:41:26Z

client/client.go

@@ -203,7 +203,9 @@ func (k *serviceModeKeeper) close() {
 	defer k.Unlock()
 	switch k.serviceMode {
 	case pdpb.ServiceMode_API_SVC_MODE:
-		k.tsoSvcDiscovery.Close()
+		if k.tsoSvcDiscovery != nil {


What about moving this check into Close()?

JmPotato · 2024-10-16T06:42:12Z

server/cluster/cluster.go

@@ -390,25 +400,85 @@ func (c *RaftCluster) checkServices() {
 	}
 }

+// checkTSOService checks the TSO service.
+func (c *RaftCluster) checkTSOService() {
+	if !c.isAPIServiceMode {


Suggested change

if !c.isAPIServiceMode {

if c.isAPIServiceMode {

return

}

JmPotato · 2024-10-16T06:42:34Z

server/cluster/cluster.go

+	if !c.isAPIServiceMode {
+		if c.member.IsLeader() {
+			if err := c.startTSOJobs(); err != nil {
+				// If there is an error, need to wait for the next check.


Do we need log here?

JmPotato · 2024-10-16T06:42:42Z

server/cluster/cluster.go

+		} else {
+			// leader exits, reset the allocator group
+			if err := c.stopTSOJobs(); err != nil {
+				// If there is an error, need to wait for the next check.


rleungx · 2024-10-17T00:56:20Z

/retest

okJiang · 2024-10-17T07:55:00Z

server/cluster/cluster.go

@@ -314,11 +322,13 @@ func (c *RaftCluster) Start(s Server) error {
 	if err != nil {
 		return err
 	}
+	c.checkTSOService()


Can we put this func next to checkSchedulingService?

prefer to check it ASAP

okJiang · 2024-10-17T08:10:46Z

server/server.go

@@ -1715,29 +1714,6 @@ func (s *Server) campaignLeader() {
 	s.member.KeepLeader(ctx)
 	log.Info(fmt.Sprintf("campaign %s leader ok", s.mode), zap.String("campaign-leader-name", s.Name()))

-	if !s.IsAPIServiceMode() {


Need we remove the comments? L1714, L1703-L1706

it still works

okJiang

rest lgtm

Signed-off-by: Ryan Leung <[email protected]>

codecov · 2024-10-21T03:17:16Z

Codecov Report

Attention: Patch coverage is 49.18033% with 31 lines in your changes missing coverage. Please review.

Project coverage is 69.94%. Comparing base (25629f2) to head (1bbc97f).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8720      +/-   ##
==========================================
- Coverage   69.97%   69.94%   -0.04%     
==========================================
  Files         517      517              
  Lines       79953    79983      +30     
==========================================
- Hits        55947    55941       -6     
- Misses      20429    20472      +43     
+ Partials     3577     3570       -7

Flag	Coverage Δ
unittests	`69.94% <49.18%> (-0.04%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

rleungx · 2024-10-21T03:21:30Z

/retest

Signed-off-by: Ryan Leung <[email protected]>

rleungx · 2024-10-21T10:22:32Z

/hold

Signed-off-by: Ryan Leung <[email protected]>

rleungx · 2024-10-21T10:55:57Z

/hold cancel

Signed-off-by: Ryan Leung <[email protected]>

okJiang · 2024-10-22T03:40:17Z

server/cluster/cluster.go

@@ -390,25 +400,76 @@ func (c *RaftCluster) checkServices() {
 	}
 }

+// checkTSOService checks the TSO service.
+func (c *RaftCluster) checkTSOService() {


Seems we do not need this wrap function now. We can call startTSOJobs directly.

for the upcomming PR

ti-chi-bot · 2024-10-22T06:32:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nolouch, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [nolouch]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2024-10-22T06:32:32Z

[LGTM Timeline notifier]

Timeline:

2024-10-21 07:46:27.818714314 +0000 UTC m=+250788.515504925: ☑️ agreed by nolouch.
2024-10-22 06:32:31.898409369 +0000 UTC m=+332752.595199978: ☑️ agreed by okJiang.

ti-chi-bot · 2024-10-22T06:42:57Z

@rleungx: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-integration-realcluster-test	`1bbc97f`	link	false	`/test pull-integration-realcluster-test`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 16, 2024

rleungx force-pushed the check-loop branch from 94ce97a to 0696f75 Compare October 16, 2024 06:26

ti-chi-bot bot removed the do-not-merge/needs-linked-issue label Oct 16, 2024

rleungx requested review from JmPotato and nolouch October 16, 2024 06:39

JmPotato reviewed Oct 16, 2024

View reviewed changes

rleungx force-pushed the check-loop branch from b49267d to 8fef7af Compare October 16, 2024 09:50

okJiang reviewed Oct 17, 2024

View reviewed changes

okJiang reviewed Oct 18, 2024

View reviewed changes

rleungx added 7 commits October 21, 2024 11:09

move tso to independent thread

f4ee98b

Signed-off-by: Ryan Leung <[email protected]>

fix

02c66a5

Signed-off-by: Ryan Leung <[email protected]>

fix

400e527

Signed-off-by: Ryan Leung <[email protected]>

address the comment

ff9c6b9

Signed-off-by: Ryan Leung <[email protected]>

address the comment

f891bad

Signed-off-by: Ryan Leung <[email protected]>

fix

74f9c72

Signed-off-by: Ryan Leung <[email protected]>

fix

b556318

Signed-off-by: Ryan Leung <[email protected]>

rleungx force-pushed the check-loop branch from 491064c to b556318 Compare October 21, 2024 03:10

rleungx requested review from JmPotato and okJiang October 21, 2024 03:10

nolouch approved these changes Oct 21, 2024

View reviewed changes

ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 21, 2024

fix

2a1aee2

Signed-off-by: Ryan Leung <[email protected]>

ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2024

fix

8cec8f3

Signed-off-by: Ryan Leung <[email protected]>

ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2024

fix

6479d60

Signed-off-by: Ryan Leung <[email protected]>

okJiang reviewed Oct 22, 2024

View reviewed changes

okJiang approved these changes Oct 22, 2024

View reviewed changes

ti-chi-bot bot added the lgtm label Oct 22, 2024

ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 22, 2024

Merge branch 'master' into check-loop

1bbc97f

ti-chi-bot bot merged commit 0402e15 into tikv:master Oct 22, 2024
21 of 25 checks passed

rleungx deleted the check-loop branch October 22, 2024 07:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

*: move tso to independent thread #8720

*: move tso to independent thread #8720

rleungx commented Oct 16, 2024 •

edited

Loading

JmPotato Oct 16, 2024

JmPotato Oct 16, 2024

JmPotato Oct 16, 2024

JmPotato Oct 16, 2024

rleungx commented Oct 17, 2024

okJiang Oct 17, 2024

rleungx Oct 21, 2024 •

edited

Loading

okJiang Oct 17, 2024 •

edited

Loading

rleungx Oct 21, 2024

okJiang left a comment

codecov bot commented Oct 21, 2024 •

edited

Loading

rleungx commented Oct 21, 2024

rleungx commented Oct 21, 2024

rleungx commented Oct 21, 2024

okJiang Oct 22, 2024

rleungx Oct 22, 2024

ti-chi-bot bot commented Oct 22, 2024

ti-chi-bot bot commented Oct 22, 2024

ti-chi-bot bot commented Oct 22, 2024

*: move tso to independent thread #8720

*: move tso to independent thread #8720

Conversation

rleungx commented Oct 16, 2024 • edited Loading

What problem does this PR solve?

What is changed and how does it work?

Check List

Release note

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rleungx commented Oct 17, 2024

Choose a reason for hiding this comment

rleungx Oct 21, 2024 • edited Loading

Choose a reason for hiding this comment

okJiang Oct 17, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

okJiang left a comment

Choose a reason for hiding this comment

codecov bot commented Oct 21, 2024 • edited Loading

Codecov Report

rleungx commented Oct 21, 2024

rleungx commented Oct 21, 2024

rleungx commented Oct 21, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ti-chi-bot bot commented Oct 22, 2024

ti-chi-bot bot commented Oct 22, 2024

[LGTM Timeline notifier]

ti-chi-bot bot commented Oct 22, 2024

rleungx commented Oct 16, 2024 •

edited

Loading

rleungx Oct 21, 2024 •

edited

Loading

okJiang Oct 17, 2024 •

edited

Loading

codecov bot commented Oct 21, 2024 •

edited

Loading