Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential decoding BlobIndex failure in compactionFilter #322

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix potential decoding BlobIndex failure in compactionFilter #322

wants to merge 1 commit into from

Conversation

mzygQAQ
Copy link
Contributor

@mzygQAQ mzygQAQ commented Jul 11, 2024

Fix #321

@mzygQAQ
Copy link
Contributor Author

mzygQAQ commented Jul 12, 2024

jenkins failed by unable to access 'https://github.com/tikv/rocksdb.git/': Could not resolve host: github.com
maybe it's a network problem, how can i retry this test

@mzygQAQ
Copy link
Contributor Author

mzygQAQ commented Jul 18, 2024

PTAL @Connor1996

@Connor1996
Copy link
Member

Can you add a test to cover it if possible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BlobIndex will be broken and failed to decode when zero-terminated in blob handle in compaction filter
2 participants
@mzygQAQ @Connor1996