Use stdint.h/stddef.h #16
Merged
+15
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Built tkey-signer device app. Loaded with tkey-sign-cli. Works as expected. |
dehanj
approved these changes
Aug 9, 2023
|
Tested. |
|
Yes, until we see that the rest of our apps are satisfied with these header files. I just tried device-fido and it works after including stdint.h and stddef.h in places. |
|
tkey-device-x25519 is satisfied. |
This was referenced Sep 13, 2023
Use clang's stdint.h and stddef.h instead of our own types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use clang's stdint.h and stddef.h instead of our own types. Please try it out with a device app.
Closes #21