Use QEMU_DEBUG in tkey-libs #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-D QEMU_DEBUG was mistakenly removed. It is needed to build the actual qemu_*() functions in libcommon. tkey-libs's own use of the qemu_*() functions are isolated to assert() and shouldn't increase code size. When a device app don't want to use the qemu_*() functions simply not defining QEMU_DEBUG means the function declarations in qemu_debug.h are replaced by nothing by the pre-processor.
mchack-work
force-pushed
the
qemu_debug
branch
from
31a21c1
to
98fff50
Compare
dehanj
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-D QEMU_DEBUG was mistakenly removed. It is needed to build the actual qemu_() functions in libcommon. tkey-libs's own use of the qemu_() functions are isolated to assert() and shouldn't increase code size.
When a device app don't want to use the qemu_*() functions simply not defining QEMU_DEBUG means the function declarations in qemu_debug.h are replaced by nothing by the pre-processor.