Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change license to BSD-2-Clause #49

Merged
merged 6 commits into from
Oct 17, 2024
Merged

Change license to BSD-2-Clause #49

merged 6 commits into from
Oct 17, 2024

Conversation

dehanj
Copy link
Member

@dehanj dehanj commented Oct 8, 2024

Description

  • Updated to the new license
  • Added target for compile_commands.json, and outputs for gitignore (made it easier for the next step).
  • REUSE compliant, running in CI.

Synced tk1_mem.h from tillitis-key1 and updated the license.

Type of change

  • Feature (non breaking change which adds functionality)
  • Documentation (a change to documentation)

Submission checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my changes
  • My changes are well written and CI is passing
  • I have squashed my work to relevant commits and rebased on main for linear history
  • I have added a "Co-authored-by: x" if several people contributed, either pair programming or by squashing commits from different authors.
  • I have updated the documentation where relevant (readme, dev.tillitis.se etc.)

@dehanj dehanj force-pushed the change-license branch 6 times, most recently from b0cc38f to 75bbb69 Compare October 11, 2024 12:17
Synced from main at commit cbb2ba7
This was announced on the Tillitis Blog the 2nd of October 2024, for
more info visit https://tillitis.se
As a convenience, add a make target to create compile_commands.json to
feed clangd for LSP support. Requires bear.
@dehanj dehanj marked this pull request as ready for review October 14, 2024 12:45
@dehanj dehanj force-pushed the change-license branch 3 times, most recently from 1ffdb55 to bee7430 Compare October 14, 2024 13:26
Copy link
Member

@mchack-work mchack-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me.

CI was failing because checkfmt caught whitespace in tk1_mem.h. I fixed and rebased.

I wonder if we should prepare something in RELEASE.md? We have a real code change since the last release, the row alignment in qemu, that should also be mentioned. I'm fine with these changes even if we don't prepare a release.

@dehanj
Copy link
Member Author

dehanj commented Oct 16, 2024

Good idea, added the release notes.

Will wait to merge until you have read it.

- Add REUSE configuration
- Add compliant license in LICENSES/
- Add copyright SPDX tags
- Run REUSE Compliance check in CI
An additional test that an app can be compiled against tkey-libs.
@dehanj
Copy link
Member Author

dehanj commented Oct 17, 2024

Added a build step of the test app to ci. So we at least have something in ci testing to compile an app against tkey-libs.
It won't test everything, but at least the basic stuff. Something to further build upon - and it would have caught the issue with the comment in app.lds.

@dehanj dehanj merged commit c9ec4c4 into main Oct 17, 2024
2 checks passed
@dehanj dehanj deleted the change-license branch October 17, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants