Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test-apps to newer version of tkey-libs #2

Merged
merged 8 commits into from
Sep 24, 2024
Merged

Update test-apps to newer version of tkey-libs #2

merged 8 commits into from
Sep 24, 2024

Conversation

dehanj
Copy link
Member

@dehanj dehanj commented Sep 17, 2024 •
edited
Loading

Description

This is just general maintenance of this repo, making it more up to date with our tools and libs.

  • Split the Makefile for each app, to make them less dependent on the same dependency.
  • At the same time, update to the latest version of tkey-libs.

Type of change

Please tick any that are relevant to this PR and remove any that aren't.

  • Feature (non breaking change which adds functionality)

Submission checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my changes
  • I have tested and verified my changes on target
  • My changes are well written and CI is passing
  • I have squashed my work to relevant commits and rebased on main for linear history
  • I have added a "Co-authored-by: x" if several people contributed, either pair programming or by squashing commits from different authors.
  • I have updated the documentation where relevant (readme, dev.tillitis.se etc.)

@dehanj dehanj force-pushed the separate_makefiles branch 2 times, most recently from 7166974 to 29446db Compare September 17, 2024 12:11
@dehanj
Separate the Makefiles and targets for each app
2368122 
Remove the need that each app must have the same tkey-libs version to
build.
@dehanj
Update gitignore and remove dependency on winres
135191a
@dehanj
Update go dependencies on runtimer/runtimer
81b80d5 
Removes an issue that prevents go.bug.st/serial from being built on
darwin
@dehanj dehanj marked this pull request as ready for review September 17, 2024 12:45
@dehanj dehanj changed the title Separate makefiles Update test-apps to newer versions Sep 17, 2024
@dehanj dehanj changed the title Update test-apps to newer versions Update test-apps to newer version of tkey-libs Sep 17, 2024
@mchack-work
Remove .go from .editorconfig
6ec4563
@mchack-work
Use golangci-lint as Github Action
66b0fca 
- Remove gotools.
- Use golangci-lint in CI.
- Change lint config to not compplain.
@mchack-work
Clarify README
52ae4b4 
Describe how different apps behave.
@mchack-work
Copy link
Member

I removed gotools, added golangci-lint to Github Action, removed .go from .editorconfig.

Tested through all apps. Realized the README needed updating. I was particularly confused that run-timer didn't actually load the timer until I looked in the code.

Merging this.

mchack-work
mchack-work approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@mchack-work mchack-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mchack-work mchack-work merged commit 52ae4b4 into main Sep 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchack-work mchack-work mchack-work approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dehanj @mchack-work