-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Send Destination function #207
base: main
Are you sure you want to change the base?
Conversation
DarkFox
commented
Sep 13, 2024
- Add support for sending a route or destination to the vehicle (Fixes Send destinations to car #8)
* Add support for sending a route or destination
This is great, the problem I see is, how does that behave when used downstream. So far the controls don't use complex objects as an input. |
That's a good point. Perhaps if we allow the value to be a dict or a list of dicts, and then have a class method in Route that creates the objects? Something like: ...
if isinstance(value, list):
Route.create_from_list(value)
... That way the validation logic can stay in there and not gunk up controls.py Edit: or allow a JSON string, which is then converted? |
I like the json idea. This needs good testing but should be a nice solution. |
Would you prefer that I squash the commits before merging, or will you just do a squash and merge? |
@tillsteinbach I was wondering if there is anything I can do to help move this forward? Are there any further code changes or testing that needs to be done? I've been running this on my own Home Assistant instance for a few weeks now, and it's working great. |
Sorry, it's just that I'm very busy. If you have a chance testing it with Weconnect-cli and Weconnect-mqtt, this is what is left for me to merge it. |
I understand, it's no problem at all. I'll take a look at that ASAP. 👍 |
Apologies for the delay in finishing this PR. I've been dealing with some health issues that have impacted my ability to work on it. I was in the process of trying to figure out the correct MQTT topic to use for sending the data, but I ran into some uncertainty there. Additionally, I'm not sure I had the CLI fully operational, which further complicated things. Unfortunately, I don't currently have the bandwidth to finish this. If anyone else is interested in picking it up, I'd be happy to provide context on what I've done so far. Thanks for understanding! |
Unfortunately I don't have access to a Volkswagen anymore. If someone would be willing to test I would be happy. |