Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bound weapon spell #691

Merged
merged 2 commits into from
Jun 24, 2024
Merged

fix bound weapon spell #691

merged 2 commits into from
Jun 24, 2024

Conversation

otsffs
Copy link
Contributor

@otsffs otsffs commented Jun 16, 2024

close #689

maximegmd
maximegmd requested changes Jun 16, 2024
View reviewed changes
Code/client/Games/Skyrim/Forms/MagicItem.cpp Outdated
{
for (EffectItem* pEffect : listOfEffects)
{
if (pEffect->pEffectSetting->eArchetype == EffectArchetypes::ArchetypeID::kBoundWeapon)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we sure pEffectSetting is always valid?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add nullptr checks

@Force67 Force67 merged commit c81e6da into tiltedphoques:dev Jun 24, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximegmd maximegmd maximegmd requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@otsffs @maximegmd @Force67