Fix getexe warning #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
あ、コミットミスっとる |
kuuote
force-pushed
the
fix-getexe_warning
branch
from
7eeb999
to
ca2a5f4
Compare
natsukium
reviewed
Oct 17, 2024
Comment on lines
+8
to
13
| let | ||
| pname = "nikuussay"; | ||
| in | ||
| stdenv.mkDerivation (finalAttrs: { | ||
| inherit pname; | ||
| version = "1.0.0"; |
There was a problem hiding this comment.
stdenv.mkDerivation は不動点コンビネータを使って再帰していくことができるのですが、変数を let で束縛してしまうとオーバーライドした際に他で使われている箇所の変更ができません。
なので stdenv.mkDerivation の引数には self: { a = 1; b = self.a + 1; } のような関数を渡すのが望ましいです。
nix-repl> pname = "kuusay"
nix-repl> ((stdenv.mkDerivation {
inherit pname;
version = "1.0.0";
passthru.pname = pname;
}).overrideAttrs (_: { pname = "nikuussay"; })).pname
"kuusay"
nix-repl> ((stdenv.mkDerivation (finalAttrs: {
pname = "kuusay";
version = "1.0.0";
passthru.pname = finalAttrs.pname;
})).overrideAttrs (_: { pname = "nikuussay"; })).pname
"nikuussay"
| @@ -26,4 +29,6 @@ stdenv.mkDerivation (finalAttrs: { | |||
| runHook postInstall | |||
| ''; | |||
|
|
|||
| meta.mainProgram = pname; | |||
There was a problem hiding this comment.
上の説明に従うと finalAttrs.pname と書くべきですが、実はここは変更されたくありません。
今回の場合はパッケージの名前とコマンドの名前がたまたま一致したケースであり、一般に mainProgram と pname の間には関連がないのでやや冗長にはなりますが
meta.mainProgram = "nikuussay";
とするのが良いです。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
evaluation warningがうるさくてyasu活に集中できない