Backport to 2.13.x: #6377: Use processed group clauses in PG16 #6378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latest version of Postgres introduced an optimization which removes redundant grouping and DISTINCT columns. This optimization needs to be taken into account when generating pushdown aggregation plans so we can create valid plans with correct grouping columns. (cherry picked from commit c81ae6f)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.13.x #6378 +/- ##
=========================================
Coverage ? 82.42%
=========================================
Files ? 249
Lines ? 57816
Branches ? 12868
=========================================
Hits ? 47652
Misses ? 6707
Partials ? 3457 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated backport of #6377: Use processed group clauses in PG16.
This PR will be merged automatically after all the relevant CI checks pass. If this fix should not be backported, or will be backported manually, just close this PR. You can use the backport branch to add your changes, it won't be modified automatically anymore.
For more details, please see the documentation
Original description
Use processed group clauses in PG16
Latest version of Postgres introduced an optimization which removes redundant grouping and DISTINCT columns. This optimization needs to be taken into account when generating pushdown aggregation plans so we can create valid plans with correct grouping columns.