Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector agg: skip entire null words of filter bitmap #7569

Merged
merged 6 commits into from
Feb 3, 2025

Conversation

akuzm
Copy link
Member

@akuzm akuzm commented Jan 6, 2025

This improves the performance for highly selective filters.

Disable-check: force-changelog-file

This improves the performance for highly selective filters.
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.34%. Comparing base (59f50f2) to head (a3a9f8e).
Report is 728 commits behind head on main.

Files with missing lines Patch % Lines
tsl/src/nodes/vector_agg/grouping_policy_hash.c 86.95% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7569      +/-   ##
==========================================
+ Coverage   80.06%   81.34%   +1.27%     
==========================================
  Files         190      241      +51     
  Lines       37181    44753    +7572     
  Branches     9450    11173    +1723     
==========================================
+ Hits        29770    36404    +6634     
- Misses       2997     3958     +961     
+ Partials     4414     4391      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philkra philkra added this to the TimescaleDB 2.18.0 milestone Jan 9, 2025
@akuzm
Copy link
Member Author

akuzm commented Jan 9, 2025

I'll remove it from the 2.18 milestone, because I want to check more things and this optimization is not strictly necessary.

@akuzm akuzm removed this from the TimescaleDB 2.18.0 milestone Jan 9, 2025
@akuzm akuzm mentioned this pull request Jan 29, 2025
10 tasks
@akuzm akuzm enabled auto-merge (squash) January 30, 2025 14:13
Signed-off-by: Alexander Kuzmenkov <[email protected]>
@akuzm akuzm disabled auto-merge January 30, 2025 16:09
@akuzm akuzm enabled auto-merge (squash) February 3, 2025 15:59
@akuzm akuzm merged commit db5e246 into timescale:main Feb 3, 2025
47 of 48 checks passed
@akuzm akuzm deleted the skip-words branch February 3, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants