Add error for DELETE triggers with transition tables #7574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7574 +/- ##
==========================================
+ Coverage 80.06% 82.34% +2.28%
==========================================
Files 190 238 +48
Lines 37181 43820 +6639
Branches 9450 11006 +1556
==========================================
+ Hits 29770 36085 +6315
- Misses 2997 3398 +401
+ Partials 4414 4337 -77 ☔ View full report in Codecov by Sentry. |
gayyappan
approved these changes
Jan 7, 2025
mkindahl
changed the title
mkindahl
force-pushed
the
test-compression-transition-table
branch
from
17f36ac to
539a797
Compare
mkindahl
force-pushed
the
test-compression-transition-table
branch
from
539a797 to
6e23edb
Compare
mkindahl
force-pushed
the
test-compression-transition-table
branch
2 times, most recently
from
6c28cee to
01378ab
Compare
mkindahl
force-pushed
the
test-compression-transition-table
branch
7 times, most recently
from
ccb84ca to
8ef1f4d
Compare
fabriziomello
approved these changes
Jan 14, 2025
mkindahl
force-pushed
the
test-compression-transition-table
branch
2 times, most recently
from
6d53080 to
0dd9569
Compare
DELETE triggers cannot be supported for compressed tables not using the hypercore table access method since it can delete an entire compressed segment and a transition table is not built for this case, so generating an error for this case. This commit also adds a bunch of tests for triggers with transition tables for normal compressed tables and extend the hypercore trigger tests.
mkindahl
force-pushed
the
test-compression-transition-table
branch
from
0dd9569 to
93cd5c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DELETE triggers cannot be supported for compressed tables not using the hypercore table access method since it can delete an entire compressed segment and a transition table is not built for this case, so generating an error instead.
This commit also adds a bunch of tests for triggers with transition tables for normal compressed tables and extend the hypercore trigger tests.
Disable-check: force-changelog-file