Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run the nightly CI tests on the release branch #7628

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

pallavisontakke
Copy link
Contributor

@pallavisontakke pallavisontakke commented Jan 28, 2025

, e.g. 2.18.x

Disable-check: force-changelog-file
Disable-check: commit-count

@pallavisontakke
Copy link
Contributor Author

#7628 is the tentative PR for this.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.28%. Comparing base (59f50f2) to head (6358040).
Report is 731 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7628      +/-   ##
==========================================
+ Coverage   80.06%   81.28%   +1.21%     
==========================================
  Files         190      241      +51     
  Lines       37181    44765    +7584     
  Branches     9450    11169    +1719     
==========================================
+ Hits        29770    36386    +6616     
- Misses       2997     3978     +981     
+ Partials     4414     4401      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@svenklemm svenklemm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release branch should be determined programmatically, not hard coded

@pallavisontakke pallavisontakke force-pushed the run_nightly_tests_on_release_branch_668 branch from 3bc5897 to c948e75 Compare February 5, 2025 05:08
@pallavisontakke pallavisontakke force-pushed the run_nightly_tests_on_release_branch_668 branch from c8a8307 to f55493f Compare February 5, 2025 10:20
Call coverity test weekly on the minor version branch.
Copy link
Contributor

@philkra philkra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if need this additional verbosity in naming, as the checkout action will yield the branch name anyway. If we do, then please consider my change requests.

- name: Read configuration
id: config
run: python .github/gh_config_reader.py

abi_test:
name: ABI Test ${{ matrix.dir }} PG${{ matrix.pg }}
name: ABI Test ${{ matrix.dir }} PG${{ matrix.pg }} timescaledb${{ github.event.inputs.branch }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: ABI Test ${{ matrix.dir }} PG${{ matrix.pg }} timescaledb${{ github.event.inputs.branch }}
name: ABI Test ${{ matrix.dir }} PG${{ matrix.pg }} timescaledb:${{ github.event.inputs.branch }}

jobs:
apt_tests:
name: APT ARM64 ${{ matrix.image }} PG${{ matrix.pg }}
name: APT ARM64 ${{ matrix.image }} PG${{ matrix.pg }} timescaledb${{ github.event.inputs.branch }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: APT ARM64 ${{ matrix.image }} PG${{ matrix.pg }} timescaledb${{ github.event.inputs.branch }}
name: APT ARM64 ${{ matrix.image }} PG${{ matrix.pg }} timescaledb:${{ github.event.inputs.branch }}

jobs:
apt_tests:
name: APT ${{ matrix.image }} PG${{ matrix.pg }} ${{ matrix.license }}
name: APT ${{ matrix.image }} PG${{ matrix.pg }} timescaledb${{ github.event.inputs.branch }} ${{ matrix.license }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: APT ${{ matrix.image }} PG${{ matrix.pg }} timescaledb${{ github.event.inputs.branch }} ${{ matrix.license }}
name: APT ${{ matrix.image }} PG${{ matrix.pg }} ${{ matrix.license }} timescaledb:${{ github.event.inputs.branch }}

jobs:

coverity:
name: Coverity ${{ matrix.pg }}
name: Coverity ${{ matrix.pg }} timescaledb${{ github.event.inputs.branch }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: Coverity ${{ matrix.pg }} timescaledb${{ github.event.inputs.branch }}
name: Coverity ${{ matrix.pg }} timescaledb:${{ github.event.inputs.branch }}

jobs:
docker_tests:
name: ${{ matrix.image }}
name: ${{ matrix.image }} timescaledb${{ github.event.inputs.branch }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: ${{ matrix.image }} timescaledb${{ github.event.inputs.branch }}
name: ${{ matrix.image }} timescaledb:${{ github.event.inputs.branch }}

- name: Read configuration
id: setter
run: python .github/gh_config_reader.py

sanitizer:
# Change the JOB_NAME variable below when changing the name.
# Don't use the env variable here because the env context is not accessible.
name: PG${{ matrix.pg }} Sanitizer ${{ matrix.os }}
name: PG${{ matrix.pg }} Sanitizer ${{ matrix.os }} timescaledb${{ github.event.inputs.branch }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: PG${{ matrix.pg }} Sanitizer ${{ matrix.os }} timescaledb${{ github.event.inputs.branch }}
name: PG${{ matrix.pg }} Sanitizer ${{ matrix.os }} timescaledb:${{ github.event.inputs.branch }}

- name: Read configuration
id: config
run: python .github/gh_config_reader.py

abi_snapshot_test:
name: ABI Snapshot Test PG${{ matrix.pg }}
name: ABI Snapshot Test PG${{ matrix.pg }} timescaledb${{ github.event.inputs.branch }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: ABI Snapshot Test PG${{ matrix.pg }} timescaledb${{ github.event.inputs.branch }}
name: ABI Snapshot Test PG${{ matrix.pg }} timescaledb:${{ github.event.inputs.branch }}

@@ -26,7 +32,7 @@ jobs:
env:
PG_SRC_DIR: pgbuild
PG_INSTALL_DIR: postgresql
JOB_NAME: SQLsmith PG${{ matrix.pg }}
JOB_NAME: SQLsmith PG${{ matrix.pg }} timescaledb${{ github.event.inputs.branch }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
JOB_NAME: SQLsmith PG${{ matrix.pg }} timescaledb${{ github.event.inputs.branch }}
JOB_NAME: SQLsmith PG${{ matrix.pg }} timescaledb:${{ github.event.inputs.branch }}

@@ -48,7 +56,7 @@ jobs:

build:
# Change the JOB_NAME variable below when changing the name.
name: PG${{ matrix.pg }} ${{ matrix.build_type }} ${{ matrix.os }}
name: PG${{ matrix.pg }} ${{ matrix.build_type }} ${{ matrix.os }} timescaledb${{ github.event.inputs.branch }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: PG${{ matrix.pg }} ${{ matrix.build_type }} ${{ matrix.os }} timescaledb${{ github.event.inputs.branch }}
name: PG${{ matrix.pg }} ${{ matrix.build_type }} ${{ matrix.os }} timescaledb:${{ github.event.inputs.branch }}

- name: Read configuration
id: config
run: python .github/gh_config_reader.py

build:
name: Windows package PG${{ matrix.test }}
name: Windows package PG${{ matrix.test }} timescaledb${{ github.event.inputs.branch }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: Windows package PG${{ matrix.test }} timescaledb${{ github.event.inputs.branch }}
name: Windows package PG${{ matrix.test }} timescaledb:${{ github.event.inputs.branch }}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants