Allow EXPLAIN in read-only mode #7637
Open
+33
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkindahl
force-pushed
the
fix-readonly-for-explain
branch
2 times, most recently
from
15365a3 to
99f233a
Compare
Using `EXPLAIN` when `transaction_read_only` is set to `on` fails with an error. This is fixed by explicitly setting the `check_read_only` flag.
mkindahl
force-pushed
the
fix-readonly-for-explain
branch
from
99f233a to
226a8d3
Compare
|
@gayyappan, @antekresic: please review this pull request.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7637 +/- ##
==========================================
+ Coverage 80.06% 81.34% +1.27%
==========================================
Files 190 241 +51
Lines 37181 44724 +7543
Branches 9450 11164 +1714
==========================================
+ Hits 29770 36381 +6611
- Misses 2997 3955 +958
+ Partials 4414 4388 -26 ☔ View full report in Codecov by Sentry. |
| @@ -0,0 +1 @@ | |||
| Fixes: #7637 Allow EXPLAIN in read-only mode | |||
There was a problem hiding this comment.
Add a thanks section for the community user.
fabriziomello
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
EXPLAINwhentransaction_read_onlyis set toonfails with an error. This is fixed by explicitly setting thecheck_read_onlyflag.Fixes #7635