detect_face bug-fix for list of torch tensors #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this would break |
|
is that the only change required to make it work for batch of torch.tensors? did you face any other issues like mismatch in mask shape |
|
Sorry. It was a while ago. I can't quite remember how I managed to do it. |
timesler
reviewed
Aug 2, 2024
| @@ -35,7 +35,7 @@ def detect_face(imgs, minsize, pnet, rnet, onet, threshold, factor, device): | |||
| else: | |||
| if not isinstance(imgs, (list, tuple)): | |||
| imgs = [imgs] | |||
| if any(img.size != imgs[0].size for img in imgs): | |||
| if any(img.size() != imgs[0].size() for img in imgs): | |||
There was a problem hiding this comment.
Does this change break the ability to pass in lists of PIL images?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug-fix
.sizeinstead ofsize().sizeis the method.size()is the correct equivalent toshape