add loader for file: URLs #65
Conversation
- Remove `C` local context abstraction - Remove `LiteralString` type - Hide metadata in `List`, `Entry` and `Indexed`.
Improve context types.
Add `serde` feature.
Upgrade `grdf` to version 0.21 Upgrade `nquads-syntax` to version 0.16
Upgrade `rdf-types` to version 0.18 Upgrade `json-syntax` to version 0.10 Upgrade `grdf` to version 0.22 Upgrade `nquads-syntax` 0.17
There was a problem hiding this comment.
That sounds great thanks! My only caveat is the use of the url crate where the iref crate already handles URLs through the Uri type. URLs and URIs are equivalents.
Also maybe add a description to the PR next time please 😃
| @@ -43,6 +44,7 @@ pretty_dtoa = "0.3" | |||
| mime = "0.3" | |||
| reqwest = { version = "^0.11", optional = true } | |||
| bytes = { version = "^1.3", optional = true } | |||
| url = { version = "2.4.1", optional = true } | |||
There was a problem hiding this comment.
The iref crate already handles URLs through the Uri/UriBuf type.
| if !url_str.starts_with("file:") { | ||
| return Err(Error::NotFileUrl(url_str.into())); | ||
| } | ||
| let url_parsed = Url::parse(url_str).map_err(Error::InvalidUrl)?; |
There was a problem hiding this comment.
You can use Iri::as_uri for that.
| { | ||
| async move { | ||
| let url_str = vocabulary.iri(&url).unwrap().as_str(); | ||
| if !url_str.starts_with("file:") { |
There was a problem hiding this comment.
You can use:
let url = vocabulary.iri(&url).unwrap();
if url.scheme() != "file" {
// ...
}
I agree that this is redundant, but the reason I used the
oops, sorry about that! 😨 |
timothee-haudebourg
force-pushed
the
master
branch
from
27c0a80 to
bc5ebdc
Compare
You're right, I should add a similar function into |
No description provided.