Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mps support #120

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Mps support #120

wants to merge 2 commits into from

Conversation

BenRogersNewsome
Copy link

@BenRogersNewsome BenRogersNewsome commented Jan 24, 2025 •
edited
Loading

Added support for MPS graphics when using torchgate. Changes:

  • Set PYTORCH_ENABLE_MPS_FALLBACK=1 when using MPS so that 'aten::unfold_backward' doesn't fail (see General MPS op coverage tracking issue pytorch/pytorch#77764)
  • Set the dtype used in SpectralGate._read_chunk to the same datatype as the input data. This is needed since the chunks were always getting set to float64 which isn't supported on MPS. This way, any data type can be used.

@BenRogersNewsome BenRogersNewsome force-pushed the mps-support branch 3 times, most recently from ed66e9d to 73e7028 Compare January 24, 2025 14:35
@BenRogersNewsome
Allow mps device but set PYTORCH_ENABLE_MPS_FALLBACK
bb353c3 
This is needed since the operator 'aten::unfold_backward' is not currently implemented for MPS in pytorch - see pytorch/pytorch#77764
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@BenRogersNewsome