Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Whats-new pages fixes #2199

Merged
merged 8 commits into from
Sep 17, 2024
Merged

✨ Whats-new pages fixes #2199

merged 8 commits into from
Sep 17, 2024

Conversation

joshbermanssw
Copy link
Contributor

@joshbermanssw joshbermanssw commented Sep 16, 2024 •
edited
Loading

For PBI #2189

  • Removes broken links on /whats-new/tinacloud page
  • Adds glass effect to cards on both /whats-new pages
  • Changes wording from 'See More' to 'See more on GitHub' to indicate external link
  • Adds link to all newsletter pages from both /whats-new pages
Screenshot 2024-09-16 at 1 14 01 PM **Figure: 🍸 Glass effect on cards**

@joshbermanssw joshbermanssw requested a review from a team as a code owner September 16, 2024 02:30
@vercel Vercel
Copy link

vercel bot commented Sep 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tina-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 11:56pm

@joshbermanssw joshbermanssw mentioned this pull request Sep 16, 2024
Closed
@joshbermanssw joshbermanssw changed the title 🔗 Removing Private Links ✨ Whats-new pages fixes Sep 16, 2024
@joshbermanssw joshbermanssw marked this pull request as draft September 16, 2024 02:39
@joshbermanssw joshbermanssw marked this pull request as ready for review September 16, 2024 03:14
bradystroud
bradystroud requested changes Sep 16, 2024
View reviewed changes
components/ui/DynamicLink.tsx Outdated Show resolved Hide resolved
isaaclombardssw
isaaclombardssw approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@isaaclombardssw isaaclombardssw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

Could improve the UX with some styling change (darkening) of these on hover - see current UX below.

2024-09-17_14-23-28

@bradystroud bradystroud mentioned this pull request Sep 17, 2024
Closed
bradystroud
bradystroud approved these changes Sep 17, 2024
View reviewed changes
pages/whats-new/tinacms.tsx Outdated Show resolved Hide resolved
@joshbermanssw joshbermanssw merged commit 210eb89 into main Sep 17, 2024
4 checks passed
@joshbermanssw joshbermanssw deleted the clean-broken-whats-new-links branch September 17, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaaclombardssw isaaclombardssw isaaclombardssw approved these changes

@bradystroud bradystroud bradystroud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshbermanssw @bradystroud @isaaclombardssw