-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Fix Auto-Filled Filename for Blog Schema #2226
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
[https://outlook-1.cdn.office.net/assets/reaction/heart.png] Landon Maxwell [SSW] reacted to your message:
[cid:ssw-circle(1)_4c7259a6-23f6-49e5-b933-230ca304562e.png]
Landon Maxwell
SSW Multimedia Specialist/Videographer
Stalk: SSW People<https://www.ssw.com.au/people/Landon-Maxwell?utm_source=emailsignature> | Walk: SSW Melbourne<https://www.ssw.com.au/ssw/Company/Offices/?utm_source=emailsignature> | Talk: +61 425 360 959<https://www.ssw.com.au/ssw/Company/ContactUs.aspx>
[cid:youtube-icon_b8b5cda9-a973-4973-8763-cf3d4922e060.png] <https://www.youtube.com/c/SSWTV> [cid:linkedin-icon_b153ac9a-eb66-47d9-9c51-ad20b42b8a0a.png] <https://www.linkedin.com/company/ssw/> [cid:x-logo_3eb6d0d3-24fb-487d-a4a7-2e30cddc1ebf.png] <https://x.com/SSW_TV> [cid:teams-icon_552803c2-9c44-4267-b563-7fe1a7a0e589.png] ***@***.***>
TinaCMS, the #1 CMS on GitHub, is now part of the SSW family<https://adamcogan.com/2024/05/15/ssw-purchases-tinacms?utm_source=emailsignature>
…________________________________
From: Josh Berman [SSW] ***@***.***>
Sent: Wednesday, September 18, 2024 6:48:42 AM
To: tinacms/tina.io ***@***.***>
Cc: Landon Maxwell [SSW] ***@***.***>; Mention ***@***.***>
Subject: [tinacms/tina.io] ♻️ Fix Auto-Filled Filename for Blog Schema (PR #2226)
cc: @landonmaxwell<https://github.com/landonmaxwell> @bradystroud<https://github.com/bradystroud>
For PBI #2110<#2110>
Users were getting confused when they were creating blog posts with long titles and their slugs would be very very long and ugly (not good)
This was because the schema defined the 'title' with isTitle: true which meant the title was auto-filling the filename input field. We dont have much flexibility to modify this field.
In this PR i removed the isTitle: true which meant that users had to visit the filename input field (as its a required field) and purposefully choose a slug.
We have opened a PBI in the TinaCMS backlog to improve the flexibility of this component (tinacms/tinacms#4800<tinacms/tinacms#4800>)
________________________________
You can view, comment on, or merge this pull request online at:
#2226
Commit Summary
* c2a05b3<c2a05b3> remove auto filled filename
File Changes
(2 files<https://github.com/tinacms/tina.io/pull/2226/files>)
* M tina/collectionsSchema/blogs.tsx<https://github.com/tinacms/tina.io/pull/2226/files#diff-900c6847bdc044b371d10e17ae01cca454c13b3d7aa87e34a7f549ee5e2873a9> (1)
* M tina/tina-lock.json<https://github.com/tinacms/tina.io/pull/2226/files#diff-2a34f2130caf88af57a0a8ba6ce9aadaf7335a87e1280095cb5036850020b1d1> (2)
Patch Links:
* https://github.com/tinacms/tina.io/pull/2226.patch
* https://github.com/tinacms/tina.io/pull/2226.diff
—
Reply to this email directly, view it on GitHub<#2226>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ASUEEVYPQFO5NLXMKBSIHH3ZXEO4VAVCNFSM6AAAAABOM6S56KVHI2DSMVQWIX3LMV43ASLTON2WKOZSGUZTEOBXGM3DKOA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
isaaclombardssw
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues 🏑
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @landonmaxwell @bradystroud
For PBI #2110
Users were getting confused when they were creating blog posts with long titles and their slugs would be very very long and ugly (not good)
This was because the schema defined the 'title' with
isTitle: true
which meant the title was auto-filling thefilename
input field. We dont have much flexibility to modify this field.In this PR i removed the
isTitle: true
which meant that users had to visit the filename input field (as its a required field) and purposefully choose a slug.We have opened a PBI in the TinaCMS backlog to improve the flexibility of this component (tinacms/tinacms#4800)