Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Fix Auto-Filled Filename for Blog Schema #2226

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Conversation

joshbermanssw
Copy link
Contributor

cc: @landonmaxwell @bradystroud

For PBI #2110

Users were getting confused when they were creating blog posts with long titles and their slugs would be very very long and ugly (not good)

This was because the schema defined the 'title' with isTitle: true which meant the title was auto-filling the filename input field. We dont have much flexibility to modify this field.

In this PR i removed the isTitle: true which meant that users had to visit the filename input field (as its a required field) and purposefully choose a slug.

We have opened a PBI in the TinaCMS backlog to improve the flexibility of this component (tinacms/tinacms#4800)

@joshbermanssw joshbermanssw requested a review from a team as a code owner September 18, 2024 06:48
Copy link

vercel bot commented Sep 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tina-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2024 11:49pm

@landonmaxwell
Copy link
Contributor

landonmaxwell commented Sep 19, 2024 via email

Copy link
Contributor

@isaaclombardssw isaaclombardssw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues 🏑

@joshbermanssw joshbermanssw merged commit 629f7e5 into main Sep 24, 2024
4 checks passed
@joshbermanssw joshbermanssw deleted the file-name-slug-fix branch September 24, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants