👥 remove strip markdown and remark #2316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
isaaclombardssw
approved these changes
Oct 9, 2024
bradystroud
requested changes
Oct 9, 2024
bradystroud
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we had a PR #2214 to update a dependency
remarkHowever i noticed this one dependency was only being used once througout the entire code base for a singular method. Specifically it was beign used to remove markdown syntax from our .md and .mdx files so that we can index them to use in our algolia searches.
In this pr i :
stripMarkdownmethod in ourblog_helper.tsmodelled after https://github.com/zuchka/remove-markdownFigure: ✅ Algolia powered Doc search working
Figure: ✅ All test cases passing!