-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Recipe Block #2323
Merged
Merged
✨ Recipe Block #2323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
With a coat of paint this looks legit |
Co-authored-by: Brady Stroud <[email protected]>
bradystroud
requested changes
Nov 8, 2024
bradystroud
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looking forward to seeing this in the docs somewhere
Calinator444
pushed a commit
that referenced
this pull request
Nov 12, 2024
* create recipe block PoC * highlight color * ui changes * 1st attempt to make sticky * fix sticky * more ui * lhs rhs height sizing * add instruction click scroll to line * rm lhs useRef * fix LHS heighting * Recipe rendering in docs too as .mdx * sm and md view #1 * highlight lines styling back * change tooltip * template modifictions * docAndBlog fixes * make tool bar sticky * change codeblock name * handle down click arrow * bg-color match * down arrow * fixed button and void overlay * extrapolate hidden logic * upd z-index * rm index for RecipeBlock * fix rounding issues * rm border * fix scrolling * TinaCMS content update Co-authored-by: Brady Stroud <[email protected]> * closing animation * remove unneccessary content * use vars instead of arbitrary numbers * add comment * extrapolate styles * fix re-render * logic to hide the down button when the container isnt scrollable * comments * extrapolate all components * move extrapolated components to different dir * custom code field * upd next.config * rm unused steps * trying another work around * False to false * add work-around context * upd comments * TinaCMS content update Co-authored-by: Brady Stroud <[email protected]> * extrapolate monacoCodeEditor to its own file * push lock * fix docs version of recipeBlock * rm from home page --------- Co-authored-by: tina-cloud-app[bot] <58178390+tina-cloud-app[bot]@users.noreply.github.com> Co-authored-by: Brady Stroud <[email protected]>
isaaclombardssw
pushed a commit
that referenced
this pull request
Nov 12, 2024
* create recipe block PoC * highlight color * ui changes * 1st attempt to make sticky * fix sticky * more ui * lhs rhs height sizing * add instruction click scroll to line * rm lhs useRef * fix LHS heighting * Recipe rendering in docs too as .mdx * sm and md view #1 * highlight lines styling back * change tooltip * template modifictions * docAndBlog fixes * make tool bar sticky * change codeblock name * handle down click arrow * bg-color match * down arrow * fixed button and void overlay * extrapolate hidden logic * upd z-index * rm index for RecipeBlock * fix rounding issues * rm border * fix scrolling * TinaCMS content update Co-authored-by: Brady Stroud <[email protected]> * closing animation * remove unneccessary content * use vars instead of arbitrary numbers * add comment * extrapolate styles * fix re-render * logic to hide the down button when the container isnt scrollable * comments * extrapolate all components * move extrapolated components to different dir * custom code field * upd next.config * rm unused steps * trying another work around * False to false * add work-around context * upd comments * TinaCMS content update Co-authored-by: Brady Stroud <[email protected]> * extrapolate monacoCodeEditor to its own file * push lock * fix docs version of recipeBlock * rm from home page --------- Co-authored-by: tina-cloud-app[bot] <58178390+tina-cloud-app[bot]@users.noreply.github.com> Co-authored-by: Brady Stroud <[email protected]>
isaaclombardssw
added a commit
that referenced
this pull request
Nov 15, 2024
* TinaCMS content update Co-authored-by: Isaac Lombard <[email protected]> * ✨ Recipe Block (#2323) * create recipe block PoC * highlight color * ui changes * 1st attempt to make sticky * fix sticky * more ui * lhs rhs height sizing * add instruction click scroll to line * rm lhs useRef * fix LHS heighting * Recipe rendering in docs too as .mdx * sm and md view #1 * highlight lines styling back * change tooltip * template modifictions * docAndBlog fixes * make tool bar sticky * change codeblock name * handle down click arrow * bg-color match * down arrow * fixed button and void overlay * extrapolate hidden logic * upd z-index * rm index for RecipeBlock * fix rounding issues * rm border * fix scrolling * TinaCMS content update Co-authored-by: Brady Stroud <[email protected]> * closing animation * remove unneccessary content * use vars instead of arbitrary numbers * add comment * extrapolate styles * fix re-render * logic to hide the down button when the container isnt scrollable * comments * extrapolate all components * move extrapolated components to different dir * custom code field * upd next.config * rm unused steps * trying another work around * False to false * add work-around context * upd comments * TinaCMS content update Co-authored-by: Brady Stroud <[email protected]> * extrapolate monacoCodeEditor to its own file * push lock * fix docs version of recipeBlock * rm from home page --------- Co-authored-by: tina-cloud-app[bot] <58178390+tina-cloud-app[bot]@users.noreply.github.com> Co-authored-by: Brady Stroud <[email protected]> * 📝Docs - Guide to migrate from WordPress (#2411) * Added WordPress documentation to the Guides tab in the tina docs * Created the guide to convert from wordpress to tina * Polished wordpress to tina guide to fit with standards * fixed step counter * Update title, added indent for note boxes, added styling to text that require formatting (code snippets and such) * Updated title on sidebar to match "Migrate From Forestry" style * Made changes as per my conversation with Landon * fixed bolding on file name * fixed broken step * Fixed broken step at Migrating Posts section * Added code snippet for tina/config.tsx * Added instructions for mac/linux users * Updated title to add capitalisation and remove tinacloud * Added note and link to discord server * Adding steps to add the coverImage to the page * Added note to explain why this works * Fxied wording on discord warning * Updated title to match the content before it * fixed numbering * fixed m to md * added bolding to note * Removed note and emoji to remain consistent * Added prerequisite to have a basic understanding of the tina editor and the schema * reorder prerequisites to be in order * fixed .txt to .md conversion to .md to .mdx conversion * Updated javascript to typescript * updated more javascript code blocks to typescript * Added prerequisites for react * Fixed text per Matt W suggestion * Adding the demo button back – it's been a long day (#2440) Revert "temp fix-while-debugging-the-demo (PR from TinaCMS) (#2435)" This reverts commit cf78b64. * invalid site-url-faq (PR from TinaCMS) (#2443) * TinaCMS content update * TinaCMS content update * TinaCMS content update * TinaCMS content update * TinaCMS content update * TinaCMS content update * add images to PR * add newline between images * update wording --------- Co-authored-by: tina-cloud-app[bot] <58178390+tina-cloud-app[bot]@users.noreply.github.com> Co-authored-by: brookjeynes-ssw <[email protected]> * trying to create data passing between tina fields * reusable checkbox list component, parsing, other changes * TinaCMS content update Co-authored-by: Isaac Lombard <[email protected]> * TinaCMS content update Co-authored-by: Isaac Lombard <[email protected]> * TinaCMS content update Co-authored-by: Isaac Lombard <[email protected]> * TinaCMS content update Co-authored-by: Isaac Lombard <[email protected]> * TinaCMS content update Co-authored-by: Isaac Lombard <[email protected]> * TinaCMS content update Co-authored-by: Isaac Lombard <[email protected]> * TinaCMS content update Co-authored-by: Isaac Lombard <[email protected]> * TinaCMS content update Co-authored-by: Isaac Lombard <[email protected]> * TinaCMS content update Co-authored-by: Isaac Lombard <[email protected]> * TinaCMS content update Co-authored-by: Isaac Lombard <[email protected]> * TinaCMS content update Co-authored-by: Isaac Lombard <[email protected]> * TinaCMS content update Co-authored-by: Isaac Lombard <[email protected]> * TinaCMS content update Co-authored-by: Isaac Lombard <[email protected]> * TinaCMS content update Co-authored-by: Isaac Lombard <[email protected]> * TinaCMS content update Co-authored-by: Isaac Lombard <[email protected]> * TinaCMS content update Co-authored-by: Isaac Lombard <[email protected]> * TinaCMS content update Co-authored-by: Isaac Lombard <[email protected]> * TinaCMS content update Co-authored-by: Isaac Lombard <[email protected]> * TinaCMS content update Co-authored-by: Isaac Lombard <[email protected]> * TinaCMS content update Co-authored-by: Isaac Lombard <[email protected]> * TinaCMS content update Co-authored-by: Isaac Lombard <[email protected]> * TinaCMS content update Co-authored-by: Isaac Lombard <[email protected]> * TinaCMS content update Co-authored-by: Isaac Lombard <[email protected]> * TinaCMS content update Co-authored-by: Isaac Lombard <[email protected]> * TinaCMS content update Co-authored-by: Isaac Lombard <[email protected]> * TinaCMS content update Co-authored-by: Isaac Lombard <[email protected]> * adding a warning to the satisfied criteria fields telling users to save * updating comments and descriptions --------- Co-authored-by: tina-cloud-app[bot] <58178390+tina-cloud-app[bot]@users.noreply.github.com> Co-authored-by: Isaac Lombard <[email protected]> Co-authored-by: Josh Berman [SSW] <[email protected]> Co-authored-by: Brady Stroud <[email protected]> Co-authored-by: Lewis Toh [SSW] <[email protected]> Co-authored-by: Isaac Lombard [SSW] <[email protected]> Co-authored-by: brookjeynes-ssw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2320
created PoC. This PR is to just be able to show the preview environment.
If we go ahead with the PoC i will fill out the PR and polish the code (its not done anyways in terms of UI :) )
Update: we went ahead with it! This awesome component is taking life and will revamp users' docs experience.
Test passed by @bettybondoc
Figure: Tablet View
Figure: Laptop View