✨ Recipe Block #2323
Open
✨ Recipe Block #2323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
With a coat of paint this looks legit |
Co-authored-by: Brady Stroud <[email protected]>
bradystroud
requested changes
Nov 5, 2024
Comment on lines
+157
to
+172
| <TinaMarkdown | ||
| key={highlightLines} | ||
| content={codeblock} | ||
| components={{ | ||
| code_block: (props) => ( | ||
| <CodeBlockWithHighlightLines | ||
| {...props} | ||
| highlightLines={highlightLines} | ||
| /> | ||
| ), | ||
| }} | ||
| /> | ||
| </div> | ||
| ) : ( | ||
| <p>No code block available.</p> | ||
| )} |
There was a problem hiding this comment.
cc @JackDevAU
I dont like that we need to have a TinaMarkdown rich text field here to get the code block.
My suggested solution
- New custom Tina field - just a string but with a
uioverride with a nice code editor - use that here instead of
TinaMarkdown
|
+1 Accordion timing for opening/closing should be same with no delays
|
|
@joshbermanssw
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2320
created PoC. This PR is to just be able to show the preview environment.
If we go ahead with the PoC i will fill out the PR and polish the code (its not done anyways in terms of UI :) )
Update: we went ahead with it! This awesome component is taking life and will revamp users' docs experience.
Test passed by @bettybondoc
Figure: Tablet View
Figure: Laptop View