Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Refactor carousel to use NextJS' Image component #2327

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

ncn-ssw
Copy link
Member

@ncn-ssw ncn-ssw commented Oct 15, 2024

General Contributing:

Refactors the carousel component to use NextJS' image component, which will permit the use of intermediate caching for GIFs and defer content loading until image is visible

All New Content Submissions: (To be confirmed by reviewer)

  • Title is short & specific
  • Headers are logically ordered & consistent
  • Purpose of document is explained in the first paragraph
  • Procedures are tested and work
  • Any technical concepts are explained or linked to
  • Document follows structure from templates
  • All links work
  • The spelling and grammar checker has been run
  • Graphics and images are clear and useful
  • Any prerequisites and next steps are defined.

@ncn-ssw ncn-ssw requested a review from a team as a code owner October 15, 2024 22:50
Copy link

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tina-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 10:54pm

@ncn-ssw ncn-ssw changed the title Refactor carousel to use NextJS' Image component. ♻️ Refactor carousel to use NextJS' Image component Oct 15, 2024
Copy link
Contributor

@joshbermanssw joshbermanssw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - nice catch

@joshbermanssw joshbermanssw merged commit faddf71 into main Oct 16, 2024
4 checks passed
@joshbermanssw joshbermanssw deleted the ncn-cache-gifs branch October 16, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants