Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annual Pricing v2 #2360

Merged
merged 7 commits into from
Oct 23, 2024
Merged

Annual Pricing v2 #2360

merged 7 commits into from
Oct 23, 2024

Conversation

joshbermanssw
Copy link
Contributor

Annual Pricing v2 as per #2330

  • Followed designs created by Betty to create UI
  • Added extra field called annual description to the pricing component
  • Moved the tab pill to the left hand side

Screenshot 2024-10-23 at 12 57 31 pm
Figure: New Annual Pricing Tab

@joshbermanssw joshbermanssw requested a review from a team as a code owner October 23, 2024 01:57
@vercel Vercel
Copy link

vercel bot commented Oct 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tina-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 6:40am

@Marxoz
Copy link
Contributor

Marxoz commented Oct 23, 2024

@joshbermanssw

image Figure: Some minor changes to the pricing page v2
  1. The Free plan should span across the whole page (See Betty's design)
  2. @bettybondoc, Should the "All prices in USD" be horizontally centred to the buttons?

@bettybondoc
Copy link

bettybondoc commented Oct 23, 2024 •
edited by joshbermanssw
Loading

cc @Marxoz @landonmaxwell

Should the "All prices in USD" be horizontally centred to the buttons?

Yes - I think you meant vertically-centred but yes text and toggle should be vertically aligned to the center

Also, @joshbermanssw I checked the preview on mobile, I think it looks better center-aligned (sorry, I know I said to left-align!)

  • Mobile - Please fix alignment and spacing
  • Tablet/Desktop - Please vertically center-align the text with the toggle

image
Figure: Mobile View

image
Figure: Text-Toggle Alignment

@joshbermanssw
Copy link
Contributor Author

Screenshot 2024-10-23 at 4 15 21 pm

Betty test passed!!

@Marxoz
Copy link
Contributor

Marxoz commented Oct 23, 2024

@joshbermanssw @bettybondoc

image Figure: Text displayed in wrong state
  1. the "Save from..." text should be displayed when Monthly is selected. At the moment it is displayed when Annually is selected

bradystroud
bradystroud requested changes Oct 23, 2024
View reviewed changes
Copy link
Member

@bradystroud bradystroud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, a few things dont make sense though

components/blocks/Pricing.tsx Outdated Show resolved Hide resolved
components/blocks/Pricing.tsx Outdated Show resolved Hide resolved
components/blocks/Pricing.tsx Outdated Show resolved Hide resolved
bradystroud
bradystroud approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@bradystroud bradystroud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshbermanssw joshbermanssw merged commit 47bf3fa into main Oct 23, 2024
4 checks passed
@joshbermanssw joshbermanssw deleted the annual-pricingv2 branch October 23, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marxoz Marxoz Marxoz left review comments

@bradystroud bradystroud bradystroud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joshbermanssw @Marxoz @bettybondoc @bradystroud