Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 UI fixes to Key Features Component #2424

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Conversation

joshbermanssw
Copy link
Contributor

@joshbermanssw joshbermanssw commented Nov 5, 2024

As per #2406

The tasks

  • Equal left and right padding on mobile view (figure 1)
  • READ MORE button is to be left aligned on mobile view
  • Headline, body and button to be horizontally aligned on laptop view

Screenshot 2024-11-06 at 10 28 04 am
Figure 1: Equal X padding on mobile

Screenshot 2024-11-06 at 10 26 41 am
Figure 2: Headline, body and button alligned in mobile

Screenshot 2024-11-06 at 10 22 45 am
Figure 3: Cards in laptop view - all items alligned

@joshbermanssw joshbermanssw requested a review from a team as a code owner November 5, 2024 23:30
Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tina-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 11:46pm

Copy link
Contributor

@isaaclombardssw isaaclombardssw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

components/blocks/CarouselFeature.tsx Outdated Show resolved Hide resolved
@joshbermanssw joshbermanssw merged commit adf2e78 into main Nov 5, 2024
3 of 4 checks passed
@joshbermanssw joshbermanssw deleted the key-features-alignment branch November 5, 2024 23:47
isaaclombardssw added a commit that referenced this pull request Nov 6, 2024
isaaclombardssw added a commit that referenced this pull request Nov 6, 2024
Revert "🐛 UI fixes to Key Features Component  (#2424)"

This reverts commit adf2e78.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants