pixel: fix Monochrome setPixel #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set/setPixel and Get weren't using the same indices. I've taken the ones used in Get and applied them to setPixel too. This fixes testImageNoise for the monochrome image.
aykevl
commented
Oct 28, 2024
| bits := index - (offset * 8) | ||
| bits := index % 8 |
There was a problem hiding this comment.
This code looks different, but it doesn't change behavior. It's just a simplification.
aykevl
commented
Oct 28, 2024
Comment on lines
-141
to
+142
| x := index % int(img.width) | ||
| offset := index / 8 | ||
| bits := index % 8 |
There was a problem hiding this comment.
The old behavior was most certainly incorrect.
Take for example an image of size 5x2. The first pixel at (0, 0) is index 0 and x 0 (make sense).
But at position (0, 1), which is index 5, you also get index 0 and x 0. So the two pixels are stored at the same location.
There was a problem hiding this comment.
exactly, took me a while to discover that the old behavior only works on images with width multiple of 8 🤦
|
This is great, thank you very much for fixing this @aykevl Tested on badger2040 display, works as expected. Now merging. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set/setPixel and Get weren't using the same indices. I've taken the ones used in Get and applied them to setPixel too.
This fixes testImageNoise for the monochrome image.
I don't know which of the two behaviors was correct, but the one in
Getcertainly is simpler and more efficient.@deadprogram do you have a specification of the format somewhere?