-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-2524: Update: Using Comments (Comments) #3457
Merged
kemister85
merged 9 commits into
feature/7.4/DOC-2524
from
feature/7.4/DOC-2524_DOC-2527
Oct 8, 2024
Merged
DOC-2524: Update: Using Comments (Comments) #3457
kemister85
merged 9 commits into
feature/7.4/DOC-2524
from
feature/7.4/DOC-2524_DOC-2527
Oct 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kemister85
added
the
upcoming release
Documentation for features currently under development/QA
label
Sep 27, 2024
kemister85
requested review from
FarzadHayat,
ShiridiGandham,
a team,
TheSpyder,
jscasca,
Skylite73,
shanmen-tiny,
spocke,
lorenzo-pomili,
hamza0867 and
ztomaszyk
and removed request for
a team
September 30, 2024 02:53
hamza0867
approved these changes
Oct 1, 2024
MitchC1999
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, nice clean screenshots 😏
FarzadHayat
reviewed
Oct 3, 2024
FarzadHayat
reviewed
Oct 3, 2024
FarzadHayat
reviewed
Oct 3, 2024
FarzadHayat
reviewed
Oct 3, 2024
Co-authored-by: Farzad Hayat <[email protected]>
FarzadHayat
reviewed
Oct 3, 2024
Co-authored-by: Farzad Hayat <[email protected]>
FarzadHayat
approved these changes
Oct 3, 2024
Great work! 💯 |
FarzadHayat
reviewed
Oct 8, 2024
FarzadHayat
reviewed
Oct 8, 2024
FarzadHayat
approved these changes
Oct 8, 2024
Co-authored-by: Farzad Hayat <[email protected]>
kemister85
added a commit
that referenced
this pull request
Oct 8, 2024
* DOC-2524: EPIC branch initial commit. * DOC-2524: Update: Commands, Events and APIs (Comments) (#3462) * DOC-2524: Update: Embedded Mode (Comments). (#3459) * DOC-2524: Update: Introduction (Comments) (#3456) * DOC-2524: Update: Toolbar Buttons and Menu Items (Comments) (#3460) * DOC-2524: New `tinycomments` option: Comments can be made and read, but the editor is in a readonly state. (#3461) * DOC-2524: New comments option: Comments can be made and read, but the editor is in a readonly state. * DOC-2524: revert live_demo testing url. * Update modules/ROOT/examples/live-demos/comments-readonly-mode/index.js Co-authored-by: Mitchell Crompton <[email protected]> * Update modules/ROOT/examples/live-demos/comments-readonly-mode/index.js Co-authored-by: Mitchell Crompton <[email protected]> * Update modules/ROOT/partials/configuration/comments-tinycomments_access.adoc Co-authored-by: Mitchell Crompton <[email protected]> * Update modules/ROOT/partials/configuration/comments-tinycomments_access.adoc Co-authored-by: shirqa <[email protected]> * Update modules/ROOT/pages/comments-options.adoc Co-authored-by: shirqa <[email protected]> * Update modules/ROOT/examples/live-demos/comments-readonly-mode/index.js Co-authored-by: Mitchell Crompton <[email protected]> * Update modules/ROOT/partials/configuration/comments-tinycomments_access.adoc Co-authored-by: shirqa <[email protected]> * DOC-2524: file name change, remove button from demo and update headers. * Update modules/ROOT/partials/configuration/comments-tinycomments_access.adoc Co-authored-by: Shan <[email protected]> * DOC-2524: Restructured tinycomments_access.adoc, removed basic config. * Update modules/ROOT/partials/configuration/comments-tinycomments_access.adoc Co-authored-by: Mitchell Crompton <[email protected]> * Update modules/ROOT/partials/configuration/comments-tinycomments_access.adoc Co-authored-by: Mitchell Crompton <[email protected]> * Update modules/ROOT/partials/configuration/comments-tinycomments_access.adoc Co-authored-by: Mitchell Crompton <[email protected]> * Update modules/ROOT/partials/configuration/comments-tinycomments_access.adoc Co-authored-by: Mitchell Crompton <[email protected]> * Update modules/ROOT/partials/configuration/comments-tinycomments_access.adoc Co-authored-by: shirqa <[email protected]> * Update modules/ROOT/partials/configuration/comments-tinycomments_access.adoc Co-authored-by: shirqa <[email protected]> * Update modules/ROOT/partials/configuration/comments-tinycomments_access.adoc Co-authored-by: Mitchell Crompton <[email protected]> * Update modules/ROOT/partials/configuration/comments-tinycomments_access.adoc Co-authored-by: Mitchell Crompton <[email protected]> * Update modules/ROOT/partials/configuration/comments-tinycomments_access.adoc Co-authored-by: Mitchell Crompton <[email protected]> * Update modules/ROOT/examples/live-demos/comments-ui-mode/index.html Co-authored-by: tiny-ben-tran <[email protected]> --------- Co-authored-by: Mitchell Crompton <[email protected]> Co-authored-by: shirqa <[email protected]> Co-authored-by: Shan <[email protected]> Co-authored-by: tiny-ben-tran <[email protected]> * DOC-2524: Update: Callback Mode (Comments) (#3458) * DOC-2524: Callback Mode (Comments) * Revert live_demo_url from testing. * Update modules/ROOT/examples/live-demos/comments-callback/example.js Co-authored-by: Hamza Benkhaldoun <[email protected]> * Update modules/ROOT/examples/live-demos/comments-callback/index.js Co-authored-by: Hamza Benkhaldoun <[email protected]> * Update modules/ROOT/partials/configuration/tinycomments_delete_comment.adoc Co-authored-by: Hamza Benkhaldoun <[email protected]> * Update modules/ROOT/partials/configuration/tinycomments_fetch.adoc Co-authored-by: Hamza Benkhaldoun <[email protected]> * Update modules/ROOT/pages/comments-callback-mode.adoc * Update modules/ROOT/pages/comments-callback-mode.adoc * DOC-2524: move tinycomments_fetch to optional options, updated examples to reflect optional callback. * DOC-2524: fix optional options header level. * Update modules/ROOT/partials/configuration/tinycomments_lookup.adoc Co-authored-by: tiny-ben-tran <[email protected]> * Update modules/ROOT/examples/live-demos/comments-callback/example.js * Update modules/ROOT/examples/live-demos/comments-callback/index.js * Update modules/ROOT/partials/configuration/tinycomments_resolve.adoc Co-authored-by: tiny-ben-tran <[email protected]> * DOC-2524: Update comments callback demo * Update modules/ROOT/partials/configuration/tinycomments_reply.adoc Co-authored-by: Karl Kemister-Sheppard <[email protected]> * Update modules/ROOT/pages/comments-callback-mode.adoc Co-authored-by: tiny-ben-tran <[email protected]> * Update modules/ROOT/pages/comments-callback-mode.adoc Co-authored-by: tiny-ben-tran <[email protected]> * DOC-2524: update example.js and tinycomments_fetch example to match demo updates. * Update modules/ROOT/pages/comments-callback-mode.adoc Co-authored-by: Farzad Hayat <[email protected]> * Update modules/ROOT/pages/comments-callback-mode.adoc Co-authored-by: Farzad Hayat <[email protected]> * DOC-2524: Add initial comments to callback demo * DOC-2524: Fix initialDB structure * Update modules/ROOT/examples/live-demos/comments-callback/index.js Co-authored-by: Farzad Hayat <[email protected]> * Update modules/ROOT/examples/live-demos/comments-callback/example.js Co-authored-by: Farzad Hayat <[email protected]> --------- Co-authored-by: Hamza Benkhaldoun <[email protected]> Co-authored-by: tiny-ben-tran <[email protected]> Co-authored-by: Farzad Hayat <[email protected]> * DOC-2524: Update: Using Comments (Comments) (#3457) * DOC-2524: Update: Using Comments (Comments) * DOC-2524: update png files. * Update modules/ROOT/pages/comments-using-comments.adoc Co-authored-by: Farzad Hayat <[email protected]> * Update modules/ROOT/pages/comments-using-comments.adoc Co-authored-by: Farzad Hayat <[email protected]> * DOC-2524: Relocate .png in delete-a-comment. * DOC-2524: remove comment-edit-comment-ellipsis.png duplicate. * DOC-2524: add guide to replying to comment and supporting screenshots. * Update modules/ROOT/pages/comments-using-comments.adoc Co-authored-by: Farzad Hayat <[email protected]> * DOC-2524: Replace png files with hi-res. --------- Co-authored-by: Farzad Hayat <[email protected]> --------- Co-authored-by: Mitchell Crompton <[email protected]> Co-authored-by: shirqa <[email protected]> Co-authored-by: Shan <[email protected]> Co-authored-by: tiny-ben-tran <[email protected]> Co-authored-by: Hamza Benkhaldoun <[email protected]> Co-authored-by: Farzad Hayat <[email protected]>
kemister85
added a commit
that referenced
this pull request
Oct 9, 2024
* DOC-2511: TinyMCE 7.4 Release Documentation. * DOC-2524: Comments Premium Plugin Documentation Improvements (#3453) * DOC-2524: EPIC branch initial commit. * DOC-2524: Update: Commands, Events and APIs (Comments) (#3462) * DOC-2524: Update: Embedded Mode (Comments). (#3459) * DOC-2524: Update: Introduction (Comments) (#3456) * DOC-2524: Update: Toolbar Buttons and Menu Items (Comments) (#3460) * DOC-2524: New `tinycomments` option: Comments can be made and read, but the editor is in a readonly state. (#3461) * DOC-2524: New comments option: Comments can be made and read, but the editor is in a readonly state. * DOC-2524: revert live_demo testing url. * Update modules/ROOT/examples/live-demos/comments-readonly-mode/index.js Co-authored-by: Mitchell Crompton <[email protected]> * Update modules/ROOT/examples/live-demos/comments-readonly-mode/index.js Co-authored-by: Mitchell Crompton <[email protected]> * Update modules/ROOT/partials/configuration/comments-tinycomments_access.adoc Co-authored-by: Mitchell Crompton <[email protected]> * Update modules/ROOT/partials/configuration/comments-tinycomments_access.adoc Co-authored-by: shirqa <[email protected]> * Update modules/ROOT/pages/comments-options.adoc Co-authored-by: shirqa <[email protected]> * Update modules/ROOT/examples/live-demos/comments-readonly-mode/index.js Co-authored-by: Mitchell Crompton <[email protected]> * Update modules/ROOT/partials/configuration/comments-tinycomments_access.adoc Co-authored-by: shirqa <[email protected]> * DOC-2524: file name change, remove button from demo and update headers. * Update modules/ROOT/partials/configuration/comments-tinycomments_access.adoc Co-authored-by: Shan <[email protected]> * DOC-2524: Restructured tinycomments_access.adoc, removed basic config. * Update modules/ROOT/partials/configuration/comments-tinycomments_access.adoc Co-authored-by: Mitchell Crompton <[email protected]> * Update modules/ROOT/partials/configuration/comments-tinycomments_access.adoc Co-authored-by: Mitchell Crompton <[email protected]> * Update modules/ROOT/partials/configuration/comments-tinycomments_access.adoc Co-authored-by: Mitchell Crompton <[email protected]> * Update modules/ROOT/partials/configuration/comments-tinycomments_access.adoc Co-authored-by: Mitchell Crompton <[email protected]> * Update modules/ROOT/partials/configuration/comments-tinycomments_access.adoc Co-authored-by: shirqa <[email protected]> * Update modules/ROOT/partials/configuration/comments-tinycomments_access.adoc Co-authored-by: shirqa <[email protected]> * Update modules/ROOT/partials/configuration/comments-tinycomments_access.adoc Co-authored-by: Mitchell Crompton <[email protected]> * Update modules/ROOT/partials/configuration/comments-tinycomments_access.adoc Co-authored-by: Mitchell Crompton <[email protected]> * Update modules/ROOT/partials/configuration/comments-tinycomments_access.adoc Co-authored-by: Mitchell Crompton <[email protected]> * Update modules/ROOT/examples/live-demos/comments-ui-mode/index.html Co-authored-by: tiny-ben-tran <[email protected]> --------- Co-authored-by: Mitchell Crompton <[email protected]> Co-authored-by: shirqa <[email protected]> Co-authored-by: Shan <[email protected]> Co-authored-by: tiny-ben-tran <[email protected]> * DOC-2524: Update: Callback Mode (Comments) (#3458) * DOC-2524: Callback Mode (Comments) * Revert live_demo_url from testing. * Update modules/ROOT/examples/live-demos/comments-callback/example.js Co-authored-by: Hamza Benkhaldoun <[email protected]> * Update modules/ROOT/examples/live-demos/comments-callback/index.js Co-authored-by: Hamza Benkhaldoun <[email protected]> * Update modules/ROOT/partials/configuration/tinycomments_delete_comment.adoc Co-authored-by: Hamza Benkhaldoun <[email protected]> * Update modules/ROOT/partials/configuration/tinycomments_fetch.adoc Co-authored-by: Hamza Benkhaldoun <[email protected]> * Update modules/ROOT/pages/comments-callback-mode.adoc * Update modules/ROOT/pages/comments-callback-mode.adoc * DOC-2524: move tinycomments_fetch to optional options, updated examples to reflect optional callback. * DOC-2524: fix optional options header level. * Update modules/ROOT/partials/configuration/tinycomments_lookup.adoc Co-authored-by: tiny-ben-tran <[email protected]> * Update modules/ROOT/examples/live-demos/comments-callback/example.js * Update modules/ROOT/examples/live-demos/comments-callback/index.js * Update modules/ROOT/partials/configuration/tinycomments_resolve.adoc Co-authored-by: tiny-ben-tran <[email protected]> * DOC-2524: Update comments callback demo * Update modules/ROOT/partials/configuration/tinycomments_reply.adoc Co-authored-by: Karl Kemister-Sheppard <[email protected]> * Update modules/ROOT/pages/comments-callback-mode.adoc Co-authored-by: tiny-ben-tran <[email protected]> * Update modules/ROOT/pages/comments-callback-mode.adoc Co-authored-by: tiny-ben-tran <[email protected]> * DOC-2524: update example.js and tinycomments_fetch example to match demo updates. * Update modules/ROOT/pages/comments-callback-mode.adoc Co-authored-by: Farzad Hayat <[email protected]> * Update modules/ROOT/pages/comments-callback-mode.adoc Co-authored-by: Farzad Hayat <[email protected]> * DOC-2524: Add initial comments to callback demo * DOC-2524: Fix initialDB structure * Update modules/ROOT/examples/live-demos/comments-callback/index.js Co-authored-by: Farzad Hayat <[email protected]> * Update modules/ROOT/examples/live-demos/comments-callback/example.js Co-authored-by: Farzad Hayat <[email protected]> --------- Co-authored-by: Hamza Benkhaldoun <[email protected]> Co-authored-by: tiny-ben-tran <[email protected]> Co-authored-by: Farzad Hayat <[email protected]> * DOC-2524: Update: Using Comments (Comments) (#3457) * DOC-2524: Update: Using Comments (Comments) * DOC-2524: update png files. * Update modules/ROOT/pages/comments-using-comments.adoc Co-authored-by: Farzad Hayat <[email protected]> * Update modules/ROOT/pages/comments-using-comments.adoc Co-authored-by: Farzad Hayat <[email protected]> * DOC-2524: Relocate .png in delete-a-comment. * DOC-2524: remove comment-edit-comment-ellipsis.png duplicate. * DOC-2524: add guide to replying to comment and supporting screenshots. * Update modules/ROOT/pages/comments-using-comments.adoc Co-authored-by: Farzad Hayat <[email protected]> * DOC-2524: Replace png files with hi-res. --------- Co-authored-by: Farzad Hayat <[email protected]> --------- Co-authored-by: Mitchell Crompton <[email protected]> Co-authored-by: shirqa <[email protected]> Co-authored-by: Shan <[email protected]> Co-authored-by: tiny-ben-tran <[email protected]> Co-authored-by: Hamza Benkhaldoun <[email protected]> Co-authored-by: Farzad Hayat <[email protected]> * DOC-2513: TinyMCE 7.4 Release notes & community release. (#3434) * DOC-2513: TinyMCE 7.4 Release notes & community changelog. * DOC-2513: Sidebar could not be toggled until the skin was loaded. * Revert "DOC-2513: Sidebar could not be toggled until the skin was loaded." This reverts commit 847c9a9. * DOC-2513: New option to opt-in to keep math annotations with specific encodings. (#3447) * DOC-2513: New option to opt-in to keep math annotations with specific encodings. * Update modules/ROOT/pages/7.4-release-notes.adoc Co-authored-by: Farzad Hayat <[email protected]> * Update modules/ROOT/pages/7.4-release-notes.adoc --------- Co-authored-by: Farzad Hayat <[email protected]> * DOC-2513: Dialog list dropdown menus now close when the browser window resizes. (#3443) * DOC-2513: Formatter would not remove empty lines. (#3442) * DOC-2513: Formatter would not remove empty lines. * DOC-2513: copy edits. * Update modules/ROOT/pages/7.4-release-notes.adoc Co-authored-by: Farzad Hayat <[email protected]> --------- Co-authored-by: Farzad Hayat <[email protected]> * DOC-2513: Formatting indent size would be different than CodeMirror indent size. (#3441) * DOC-2513: Formatting indent size would be different than CodeMirror indent size. * DOC-2513: correct paragraph styling. * Update modules/ROOT/pages/7.4-release-notes.adoc * DOC-2513: Caret would unexpectedly shift to the `non-editable` table row above when pressing Enter. (#3437) * DOC-2513: Caret would unexpectedly go to a not editable table row above when user pressed enter. * DOC-2513: fix type in title. * DOC-2513: Mouse hover on partially visible dialog collection elements no longer scrolls. (#3435) * DOC-2513: Mouse hover on partially visible dialog collection elements no longer scrolls * Update modules/ROOT/pages/7.4-release-notes.adoc Co-authored-by: Farzad Hayat <[email protected]> * Update modules/ROOT/pages/7.4-release-notes.adoc --------- Co-authored-by: Farzad Hayat <[email protected]> * DOC-2513: Sidebar could not be toggled until the skin was loaded. (#3439) * DOC-2513: Pasting a table now places the cursor after the table instead of into the last table cell. (#3438) * DOC-2513: Pasting a table now places the cursor after the table instead of into the last table cell. * DOC-2513: move to improvements sections. * DOC-2513: Format button would lose focus after action while navigating through keyboard. (#3440) * DOC-2513: Format button would lose focus after action while navigating through keyboard. * Update modules/ROOT/pages/7.4-release-notes.adoc * Update modules/ROOT/pages/7.4-release-notes.adoc * DOC-2513: Copying tables to the clipboard did not correctly separate cells and rows for the "text/plain" MIME type. (#3449) * DOC-2513: Copying tables to the clipboard did not correctly separate cells and rows for the text/plain MIME type. * Update modules/ROOT/pages/7.4-release-notes.adoc Co-authored-by: ltrouton <[email protected]> --------- Co-authored-by: ltrouton <[email protected]> * DOC-2513: New `importword_converter_options` option that allows customizing the conversion. (#3448) * DOC-2513: New importword_converter_options option that allows customizing the conversion. * Update modules/ROOT/partials/configuration/importword.adoc Co-authored-by: Farzad Hayat <[email protected]> * Update modules/ROOT/partials/configuration/importword.adoc * DOC-2513: Copy edits, fixes and seperation of partials. --------- Co-authored-by: Farzad Hayat <[email protected]> * DOC-2513: The editor resize handle was incorrectly rendered when all components were removed from the status bar. (#3450) * DOC-2513: Add TINY-11257 release note entry * Fix grammer * Update modules/ROOT/pages/7.4-release-notes.adoc Co-authored-by: Karl Kemister-Sheppard <[email protected]> --------- Co-authored-by: Karl Kemister-Sheppard <[email protected]> * DOC-2513: The image dialog lost focus after closing an image upload error alert. (#3446) * Placing the cursor after a table with a `<br>` element would misplace added newlines before the table instead of after it. (#3445) * Placing the cursor after a table with a BR element would misplace added newlines before the table instead of after it. * Update modules/ROOT/pages/7.4-release-notes.adoc * DOC-2513: Deleting a selection in a list element would sometimes prevent the input event from being dispatched. (#3444) * DOC-2513: Insert lists will no longer unexpectedly generate indented lists. (#3466) * DOC-2513: Insert lists will no longer unexpectedly generate indented lists. * DOC-2513: update to reflect fix rather than improvement. * DOC-2513: Cursor would jump to the previous line after pressing `shift + enter` if the annotation was applied. (#3464) * DOC-2513: Cursor would jump to the previous line after pressing shift + enter if the annotation was applied. * DOC-2513: add header and link to plugin doc in release notes. * DOC-2513: As you type spellchecking did not update when scrolling with the `autoresize` plugin active. (#3465) * DOC-2513: As you type spellchecking did not update when scrolling with the plugin active. * Update modules/ROOT/pages/7.4-release-notes.adoc * Update modules/ROOT/pages/7.4-release-notes.adoc Co-authored-by: tiny-ben-tran <[email protected]> --------- Co-authored-by: tiny-ben-tran <[email protected]> * DOC-2513: Made importword_service_url, exportword_service_url and exportpdf_service_url option more fault tolerant. (#3451) * DOC-2513: In read-only mode the editor now allows normal cursor movement and block element selection, including video playback & New property for all ui components. (#3463) * DOC-2513: In read-only mode the editor now allows normal cursor movement and block element selection, including video playback & New property for all ui components. * DOC-2513: Add state update section * DOC-2513: Fix including admon in tables * DOC-2513: Copy edits. * DOC-2513: Add `context` property to Custom Dialog Components and Custom Dialog Footer Buttons. * Update modules/ROOT/pages/dialog-components.adoc * Update modules/ROOT/pages/dialog-components.adoc * Update modules/ROOT/pages/dialog-components.adoc * Update modules/ROOT/pages/dialog-footer-buttons.adoc * Update modules/ROOT/pages/dialog-footer-buttons.adoc --------- Co-authored-by: shanmen-tiny <[email protected]> Co-authored-by: Farzad Hayatbakhsh <[email protected]> * DOC-2513: Added changelog for TinyMCE 7.4 core changes. * DOC-2513: Categories can now be declared as `locked`, making them readonly. (#3467) * DOC-2513: Categories can now be declared as locked, making them readonly. * Update modules/ROOT/pages/advanced-templates.adoc * Update modules/ROOT/examples/live-demos/advtemplate-readonly-template/example.js Co-authored-by: tiny-ben-tran <[email protected]> * Update modules/ROOT/examples/live-demos/advtemplate-readonly-template/example.js Co-authored-by: tiny-ben-tran <[email protected]> * Update modules/ROOT/examples/live-demos/advtemplate-readonly-template/index.js Co-authored-by: tiny-ben-tran <[email protected]> * Update modules/ROOT/examples/live-demos/advtemplate-readonly-template/index.js Co-authored-by: tiny-ben-tran <[email protected]> * Update modules/ROOT/pages/advanced-templates.adoc Co-authored-by: Farzad Hayat <[email protected]> * Update modules/ROOT/pages/advanced-templates.adoc Co-authored-by: tiny-ben-tran <[email protected]> * DOC-2513: Add advtemplate commands to editor-command-identifiers.adoc * DOC-2513: fix store variable declaration issue, add missing semicolons and added advtemplate_get_template throw error. * Update modules/ROOT/pages/7.4-release-notes.adoc * Update modules/ROOT/pages/advanced-templates.adoc Co-authored-by: Farzad Hayat <[email protected]> * Update modules/ROOT/pages/7.4-release-notes.adoc * Update modules/ROOT/pages/advanced-templates.adoc Co-authored-by: Farzad Hayat <[email protected]> * Update modules/ROOT/pages/advanced-templates.adoc Co-authored-by: Farzad Hayat <[email protected]> * Add missing semi colons and replace double quotes with single qoutes --------- Co-authored-by: tiny-ben-tran <[email protected]> Co-authored-by: Farzad Hayat <[email protected]> * DOC-2513: copy edits, template cleanup. * DOC-2513: remove Added focus function to view button api, as duplicate. * DOC-2513: Add known issues to 7.4 release notes. --------- Co-authored-by: Farzad Hayatbakhsh <[email protected]> Co-authored-by: ltrouton <[email protected]> Co-authored-by: tiny-ben-tran <[email protected]> Co-authored-by: shanmen-tiny <[email protected]> --------- Co-authored-by: Mitchell Crompton <[email protected]> Co-authored-by: shirqa <[email protected]> Co-authored-by: Shan <[email protected]> Co-authored-by: tiny-ben-tran <[email protected]> Co-authored-by: Hamza Benkhaldoun <[email protected]> Co-authored-by: Farzad Hayat <[email protected]> Co-authored-by: ltrouton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: DOC-2524
Site: Staging branch
Changes:
Pre-checks:
feature/<version>/
,hotfix/<version>/
,staging/<version>/
, orrelease/<version>/
.Review: