Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC-2543: Add title to comments-tinycomments_access.adoc. #3469

Merged
merged 1 commit into from
Oct 9, 2024
Merged

DOC-2543: Add title to comments-tinycomments_access.adoc. #3469

merged 1 commit into from
Oct 9, 2024

Conversation

kemister85
Copy link
Contributor

Ticket: DOC-2543

Site: Staging branch

Changes:

  • Fixed page Title is coming up as "untitled"
  • Updated code snippet comments-access-options.

Pre-checks:

  • Branch prefixed with feature/<version>/, hotfix/<version>/, staging/<version>/, or release/<version>/.

Review:

  • Documentation Team Lead has reviewed

@kemister85 kemister85 requested review from spocke, ShiridiGandham and a team and removed request for a team October 9, 2024 10:21
@kemister85 kemister85 requested a review from a team as a code owner October 9, 2024 10:21
ShiridiGandham
ShiridiGandham approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@ShiridiGandham ShiridiGandham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kemister85 kemister85 merged commit 3cf0b81 into tinymce/7 Oct 9, 2024
5 checks passed
@kemister85 kemister85 deleted the hotfix/7.4/DOC-2543 branch October 9, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spocke spocke spocke approved these changes

@ShiridiGandham ShiridiGandham ShiridiGandham approved these changes

@TheSpyder TheSpyder Awaiting requested review from TheSpyder TheSpyder was automatically assigned from tinymce/editor-platform-team

@MitchC1999 MitchC1999 Awaiting requested review from MitchC1999 MitchC1999 was automatically assigned from tinymce/editor-platform-team

@tiny-ben-tran tiny-ben-tran Awaiting requested review from tiny-ben-tran tiny-ben-tran was automatically assigned from tinymce/editor-platform-team

@shanmen-tiny shanmen-tiny Awaiting requested review from shanmen-tiny shanmen-tiny was automatically assigned from tinymce/editor-platform-team

@Skylite73 Skylite73 Awaiting requested review from Skylite73 Skylite73 is a code owner automatically assigned from tinymce/documentation-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kemister85 @spocke @ShiridiGandham