Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configures pydase's logger only (not root logger anymore) #143

Merged
merged 4 commits into from
Jul 12, 2024
Merged

Conversation

mosmuell
Copy link
Member

The logging setup of pydase was configuring the root logger. This means other packages were also influenced by the log level set through the environment variable (default logging.DEBUG).

@mosmuell mosmuell added bug Something isn't working enhancement New feature or request labels Jul 11, 2024
@mosmuell
Copy link
Member Author

Fixing tests as described here: https://stackoverflow.com/a/74888617

@mosmuell
Copy link
Member Author

See here for fixing failing tests with propagate=False:
pytest-dev/pytest#3697

@mosmuell mosmuell merged commit 1789a6a into main Jul 12, 2024
9 checks passed
@mosmuell mosmuell deleted the fix/logging branch July 12, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant