[Chat] iOS 모바일에서 init 시점에 infinite scroll 로직 실행되는 오류 수정 #2868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2868 +/- ##
==========================================
- Coverage 12.33% 12.32% -0.01%
==========================================
Files 676 676
Lines 35766 35770 +4
Branches 8817 8820 +3
==========================================
Hits 4410 4410
- Misses 31350 31354 +4
Partials 6 6
☔ View full report in Codecov by Sentry. |
|
release-canary |
|
v13.2.5-pr-2868.3 has been published! |
…n 상태 사이 시간으로 변경" This reverts commit 8a7a986.
dia-triple
force-pushed
the
feat/chat-inspection
branch
3 times, most recently
from
de20bcd to
6871a8f
Compare
|
release-canary |
|
v13.2.5-pr-2868.21 has been published! |
dia-triple
force-pushed
the
feat/chat-inspection
branch
from
6871a8f to
b41e078
Compare
|
release-canary |
|
v13.2.5-pr-2868.23 has been published! |
|
release-canary |
|
v13.2.5-pr-2868.24 has been published! |
dia-triple
requested review from
inbeom,
choisohyun and
guswl98
and removed request for
a team
dongoc
approved these changes
Aug 30, 2023
choisohyun
approved these changes
Aug 30, 2023
drakang4
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 설명
Popup과 함께 쓰이는 경우, iOS 모바일 사파리에서 init 시점에 infinite scroll이 트리거 되어 bottom으로 이동하는 스크롤과, top으로 이동하는 스크롤이 중첩되는 현상이 있습니다.MINIMUM_INTERSECTING_TIME보다 항상 큽니다.변경 내역
isScrollReady플래그로 변경했습니다. 최초 메시지 로드 후 bottom으로 이동하는 커멘드가 실행되면isScrollReady가 true로 변경됩니다.체크리스트
스크린샷 & URL