Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New club announcements PR (and some other things added in) #1647

Draft
wants to merge 17 commits into
base: dev
Choose a base branch
from
Draft

New club announcements PR (and some other things added in) #1647

wants to merge 17 commits into from

Conversation

alanzhu0
Copy link
Member

Building off #1617

@alanzhu0 alanzhu0 requested a review from a team as a code owner March 29, 2024 04:25
@alanzhu0 alanzhu0 marked this pull request as draft March 29, 2024 04:25
@alanzhu0 alanzhu0 force-pushed the alan-club-announcements branch 4 times, most recently from b4bca0e to 56ea8f3 Compare April 1, 2024 02:34
@krishnans2006 krishnans2006 mentioned this pull request Apr 4, 2024
Closed
krishnans2006 and others added 11 commits April 7, 2024 00:03
@krishnans2006
feat(announcements): implement models/UI for club announcements
414935c
@krishnans2006
feat(announcements): animate club announcements on dashboard
0c11a9a
@krishnans2006
feat(announcements): filter club announcements by subscription status
fbcd55f 
also fix subscribe/unsubscribe button styling
@alanzhu0 @krishnans2006
refactor: update year on search, announcement request pages
1562899
@alanzhu0 @krishnans2006
refactor(announcements): reword guidelines and remove redundant code
af31ec9
@alanzhu0 @krishnans2006
perf(announcements): add prefetch query in status view and tighten perms
19be8e9 
Greatly reduces load time
@alanzhu0 @krishnans2006
feat(announcements): continue adding functionality and permissions
912d348
@krishnans2006
style(announcements): dark theme fixes
6dcf06c
@krishnans2006
fix(announcements): handle some edge cases
1633b0a
@krishnans2006
style(announcements): improve club announcement form
8c47d51
@krishnans2006
feat(eighth): add subscribe and unsubscribe buttons everywhere
62a9f8a
@alanzhu0
Copy link
Member Author

If you want to contribute to this PR, ask me for push access to the branch or rebase off this branch on your own fork.

@alanzhu0 alanzhu0 mentioned this pull request Sep 18, 2024
Open
@shrysjain
Copy link
Member

Club announcements features left to add:

  • Archive
  • Search
  • Restrict subscriptions for restricted activities to only those on the authorized list

@alanzhu0
Copy link
Member Author

alanzhu0 commented Sep 18, 2024 •
edited
Loading

Also (small things):

  • Automatically subscribe the club's sponsors to the club's announcements on save
  • For this text on the request post page: "Want to post an announcement for your club's members? Submit a club announcement instead!" add it for club sponsors as well (currently only for club officers).
  • Remove the homecoming banner from the club announcements page.
  • Rewrite intranet/apps/eighth/views/activities.py, lines 60-64 and intranet/templates/eighth/take_attendance.html, line 500 to allow both the eighth activity sponsors and the club announcements sponsors to edit settings.
  • For our initial beta rollout - include some text on the club announcements page that says "Club announcements is a new Ion feature that enables clubs to better communicate with their members. It is currently in beta release and is only available to select clubs. If your club is interested in participating in the rollout, contact [email protected]. The feature will be released to the entire TJ community in the near future."

@JasonGrace2282
Copy link
Member

JasonGrace2282 commented Sep 19, 2024 •
edited
Loading

Also add tests along the way :)

@shrysjain
Copy link
Member

new: force sponsors to be subscribed to announcements

@JasonGrace2282 JasonGrace2282 mentioned this pull request Oct 2, 2024
Merged
@JasonGrace2282
Copy link
Member

Development has now moved to #1724

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@krishnans2006 krishnans2006

@alanzhu0 alanzhu0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alanzhu0 @shrysjain @JasonGrace2282 @krishnans2006