Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JQuery from 1.12.4 to 3.7.1 and remove references to jquery.cookie #1701

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

aarushtools
Copy link
Member

@aarushtools aarushtools commented Jul 3, 2024

Proposed changes

  • Change all deprecated functions/syntax to its modern equivalent so jquery 3.7.1 can work (i.e. .click() -> .trigger("click"))
  • Remove references to jquery.cookie (which does not support jquery 3 and was archived in 2017) and instead use js-cookie which is already used in other files such as this one

Brief description of rationale

JQuery 1.12 is EOL, as well as jquery.cookie

@aarushtools aarushtools force-pushed the jq-update branch 3 times, most recently from 022d2ad to be9b840 Compare July 3, 2024 23:54
@coveralls
Copy link

Coverage Status

coverage: 79.447% (+0.04%) from 79.412%
when pulling be9b840 on aarushtools:jq-update
into 1d1ff53 on tjcsl:dev.

@aarushtools aarushtools marked this pull request as ready for review July 4, 2024 00:14
@aarushtools aarushtools requested a review from a team as a code owner July 4, 2024 00:14
@coveralls
Copy link

Coverage Status

coverage: 79.447% (+0.04%) from 79.412%
when pulling be9b840 on aarushtools:jq-update
into 1d1ff53 on tjcsl:dev.

@coveralls
Copy link

Coverage Status

coverage: 79.452% (-0.02%) from 79.468%
when pulling fd2c29f on aarushtools:jq-update
into f164994 on tjcsl:dev.

@alanzhu0
Copy link
Member

Does JQuery require .on("click", ...? I prefer .click(...

@aarushtools
Copy link
Member Author

aarushtools commented Aug 13, 2024

Does JQuery require .on("click", ...? I prefer .click(...

Yeah .click is deprecated since 3.3 so they could separate out .click() into .trigger("click") and .click(...) to .on("click", ...)

@coveralls
Copy link

Coverage Status

coverage: 79.341%. remained the same
when pulling b32da03 on aarushtools:jq-update
into 1888e89 on tjcsl:dev.

@alanzhu0
Copy link
Member

alanzhu0 commented Oct 6, 2024

Sorry for late review...if you can resolve merge conflicts I'll merge asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants