[pull] master from novnc:master #61
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Makes sure everything behaves the same way, even if there is no visible UI for a settings.
Makes it easier to see how things are connected.
Expose a simple and stable API to override default settings, and force settings that users shouldn't be able to change.
Make it even easier to customize things by loading the settings from separate configuration files.
It returns an object with details, not just a simple boolean.
Avoid duplicating this logic in multiple places.
So that we can use await at module top level.
Firefox is buggy and reports support for H.264 but then throws errors once we actually try to decode things. Detect this early by doing a quick test decode of a single frame.
These are not supposed to happen according to the specification, but Firefox has some bug and throws them anyway.
The Firefox H.264 decoder on Windows might simply just refuse to deliver any finished frames. It also doesn't deliver any errors. Detect this early by expecting a frame after flush() has completed.
Try to be more consistent in how we capitalize things. Both the "Title Case" and "Sentence case" styles are popular, so either would work. Google and Mozilla both prefer "Sentence case", so let's follow them.
This would have resolved itself automatically on the next translation update, but this commit will reduce unnecessary noise in that change.
node-getopt isn't maintained and nodejs has started complaining about deprecated features in it.
The former doesn't seem to be properly maintained and nodejs gives deprecation warnings.
Since the expected client size wasn't updated when the browser window resized, noVNC didn't resize the canvas properly when going back to the exact same dimensions. Fixes issue #1903
This is what we use in every other file in noVNC. It also much more common for a CSS file in general. By standardizing on 4 spaces we can avoid indentation mistakes.
Gives them a more modern and spacious look.
To make stuff feel less cramped, lets add some margin here. As of comitting this, it only affects the logging-level select dropdown in the settings, but this is a general rule of thumb. It doesn't apply to checkboxes or radios since they have a margin by default, and their label to the left.
These functions can be used elsewhere in the tests. We want to use these in the dragging tests in the future instead of directly calling private methods.
This makes buttons and slider stand out more.
Note that no color picker elements are currently in use, this is for completeness.
Modern interfaces are less cramped, this makes noVNC feel more up to date. Note that this required some adjustments on noVNC_headings and noVNC_connect_button since the text now takes up more height than the images.
These are a type of checkbox that is suitable for ON/OFF-type switches.
These settings are well suited to use toggle switches. This makes these settings more approachable and user-friendly.
This is a type of select box that doesn't appear like a button, but more like a textarea that lists options. It is not currently used, but added for completeness.
Fits better with the new slightly rounded and spacious style. The track was made slightly thicker to ensure proper centering of the new thumb.
Makes it easier to envision the value is selected.
Makes the heading pop a bit more in the new airier layout.
Dialogs have had text inputs and buttons cramped together without space between, this fixes that.
Make the color contrast with the background and the button more rounded. The goal is to make the button stand out.
Both labels and inputs protruded outside the panel on for example a phone in portrait mode. This commit fixes that by allowing wrapping and setting a max-width. Since the --input-xpadding variable is now used in two different CSS files, it was moved to constants.css.
Some new CSS incorrectly give errors from validator.w3.org. Issues were opened in that repo, so hopefully we can remove these exceptions soon. I searched for alternative validators, but couldn't find a different one that had a simple API like this one. In order to reliably detect & handle these exceptions we unfortunately need to make the validator output parsing quite a bit more complicated.
A very slight change to the background color, to make the contrast better with the light-grey input elements.
We shouldn't expect a resize request to be sent if the container didn't change size first.
There might be subtle changes in behaviour, so we should mimic what a real server does.
Be more aggressive with resizing, limiting it to once ever 100 ms instead of after a 500 ms idle period. This gives a more responsive user experience.
Signed-off-by: tianzedavid <[email protected]>
chore: fix some typos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )